update og_mandatory_group for Drupal 4.7

I have, I think, corrected the next bug "warning: Invalid argument supplied for foreach()" on line 33 of the module in the attached patch. Thanks to Zack who's 4.7 port of this module at www.zacker.org had this line corrected and confirmed my thought as to how to fix it.

I also prevented the remainder of the errors by commenting out a call to the user.module function "user_access()" on line 62. Not a real fix, but
(for me at least) there is no loss in functionality because the function call resulted in an error anyhow. The purpose of the function call is to determine whether to add a helpful line to the notification e-mail.

eurka- I think I found the problem. The last batch of errors are from this function:

http://api.drupal.org/api/HEAD/function/user_access

The implode statment references: $account->roles

However, in og.module, the SQL query returns only some fields from {user} and {og_user}
In contrast, the user_access() function expects the full $user object generated by
user_load() which includes #user->roles. So, the function call to user_access,/code> is passing an invalid parameter.

Ok, after my insight above and too much browsing of user.module, I think the attached patch brings the full intended functionality to this module. Tested using 4.7RC3, PHP 4.3.10, mySQL 4.0.25. Please review/test/commit and maybe move this module back into the 4.7 branch of OG.

-Peter

The full (most recent) patch should not only make the scary error messages go away, but also any group admins who have the 'administer users' permission should now have received an e-mail that includes a link to administer the account of the newly-joined user.

-Peter

I'm pretty confident that this patch is, indeed, ready to be committed. Please let me know...

@killes - thanks for reviewing this.

I'm looking at the code with a fresh eye and I'm now thinking, perhaps, the foreach is needed, but the usage was wrong in some other way. This current patch has been working for me since I don't have any groups available during registration.

A better patch to follow.

Below is a fragment of the code from og.module for the 'insert' case in hook_user. From the SQL query, it looks as though this was changed as part of the "let any node be a group" reform.

I will use this same logic in place of the foreach().

function og_user($op, &$edit, &$account, $category = NULL) {
  global $user;

  switch ($op) {

...
    case 'insert':
      $result = db_query(db_rewrite_sql('SELECT n.nid, n.title, o.* FROM {node} n INNER JOIN {og} o ON n.nid = o.nid WHERE n.type IN ('. str_pad('', count(variable_get('og_node_types', array('og'))) * 5 - 1, "'%s',") .') AND n.status = 1 AND o.register = 1'), variable_get('og_node_types', array('og')));
      while ($group = db_fetch_object($result)) {
        if ($edit['og_register'][$group->nid]) {
          $return = og_subscribe_user($group->nid, $account);
          if (!empty($return['message'])) {
            drupal_set_message($return['message']);
          }
        }
      }

      break;
 ...

revised patch attached- does work for me to send e-mail describing groups joined during registration form.

patched module, plus orig and README attached in a .zip for those who want to easily test the patch in #12.

Commited changes- working 4.7 version now available for download:

http://drupal.org/project/og_mandatory_group