Sorry if this has been posted, I did try to search as best I could...
I'm having a problem trying to discount some prices by half for a promotion on my site using payments >> adjustments. For my two sample items, the prices are $5,000 and $3,000. Once the re-calculated price reaches $1,000 it gets screwed up. So, I could put in 30% and the 5k item shows up as $1.00, but the 3k item is calculated properly as $900. If I increase the discount to 40%, my products now show up with prices of $2.00 and $1.00.
Any advice, workaround, or other help would be greatly appreciated!
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | payment.patch.txt | 627 bytes | wpd |
Comments
Comment #1
wpd commentedI can reproduce this in HEAD also. The problem is that number_format is called twice. It only shows up on values greater than 1,000. The comma is inserted into the first call to number_format and that screws up the result for the second call.
This patch removes the first call. There is still a call to round. We may want to think about, but I think we may need to remove all the round calls to display level. If you round at every adjustment you can end up woth incorrect results.
Comment #2
wpd commentedMy patch is for head. It is a one line fix, so it should be trivial to make the change for 4.6 also.
Comment #3
irishsuperfly commentedThank you so much for the help (and quick reply)! I made the change to payment.module and it works perfectly.
Comment #4
wpd commentedChanging settings based on irishsuperfly testing
Comment #5
gordon commentedThanks, Committed to cvs.
Comment #6
wpd commented