Use administration theme on batch processing page [#563634]

Before we get a more general framework in (http://drupal.org/node/346573), I'd like to add a small option to use the administration theme on batch processing pages. I bet 95% of batch use cases are administrative tasks and originate from the administration interface (like starting tests, deleting nodes, ...). This small patch adds this option as a checkbox after "allow administraitont heme for content editing".

Comment	File	Size	Author
#3	admin-theme-batch-forced.patch	1001 bytes	davyvdb
	admin-theme-batch.patch	2.72 KB	davyvdb

Comments

Comment #1

Bojhan commented 30 August 2009 at 11:44

Lets not make this an option, but something by default.

Comment #2

pasqualle

🇭🇺 Budapest

commented 30 August 2009 at 11:46

if that page should be displayed with admin theme, then we do not need an option. the arg(0) == 'batch' should be enough, or if the batch page path can be changed then move it to somewhere like 'admin/config/development/batch'.

Comment #3

davyvdb commented 30 August 2009 at 12:05

Status	File	Size
new	admin-theme-batch-forced.patch	1001 bytes

Mmmmh. I'm not sure about that. Forcing /admin* to show in administration theme when administration theme is on makes sence. /admin* is always for administrative tasks. Batch may sometimes be used in the front end. Albeit not quite often.

Anyway. I've provided a patch for the forced option too for if we decide to go this path.

Comment #4

30 August 2009 at 12:20

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #5

davyvdb commented 30 August 2009 at 16:03

This actually fails because of the maintenance page definition. In theme.inc we have

/**
 * Provide theme registration for themes across .inc files.
 */
function drupal_common_theme() {
  return array(
    // ...
    'maintenance_page' => array(
      'arguments' => array('content' => NULL, 'show_messages' => TRUE),
      'template' => 'maintenance-page',
      'path' => 'includes',
      'file' => 'theme.maintenance.inc',
    ),

But maintenance-page is in system module folder.

#321828: maintenance_page not registered correctly in drupal_common_theme()