Anonymous user name not set/saved correctly

Yes, and that was the wrong solution.

All checks for the anonymous user should be checking for uid == 0, and not the name.

Putting a NULL in users.name for users.uid == 0 causes problems elsewhere.

Suggested patch attached.

1. Refactor common.inc::format_name() to only format the name and do nothing else.

2. Add theme hook theme.inc::theme_format_name() to allow formatting of author name by theme, e.g. if theme needs to shorten long names or theme designer wants to otherwise modify them.

3. Modify system.module::system_view_general() and system_settings_save() to use the {users} table name value for the anonymous user instead of a value in the {variables} table.

4. Create update_78() to set the name field in {users} to the current Anonymous users name for uid 0.

5. Modify database/database.*sql to correctly create the initial {users} table entry for the anonymous user.

Yeah, the setting method is kind of ugly because the system module assumes[1] that all system settings will of course only ever be in the {variable} table.

One alternative I thought about was moving the setting of the anonymous user name to some other place where a hack would not be required, but there did not seem to be a better logical place for such a global setting.

I am open to suggestions on how to better set the anonymous name in the {users} table.

As for the SQL -- that's obviously a 5 second fix.

[1] we have an expression in the U.S. that plays with the word "assume" to create a phrase to remind people not to make assumptions, as they are nearly always wrong.

New patch attached.

1. Refactor common.inc::format_name() to only format the name and do nothing else.

2. Add theme hook theme.inc::theme_format_name() to allow formatting of author name by theme, e.g. if theme needs to shorten long names or theme designer wants to otherwise modify them.

3. Remove setting of anonymous user name in the {variable} table in the system module.

4. Create update_79() to set the name field in {users} to the current Anonymous users name for uid 0.

5. Modify database/database.*sql to correctly create the initial {users} table entry for the anonymous user.

6. Add link to admin/user/edit/0 in both admin/config (legacy location) and admin/config/modules/user (per Goba's suggestion).

7. Fix user.module to prevent deletion of uid 0.

8. Modify user.module to present only those form items which it is sane to change for uid 0.

Over all goal: remove variable "anonymous" and instead use the users table entry for anonymous for the displayed name, to make it less confusing and cleaner.