We no longer have any moderation in core, and haven't since Drupal 5, but the moderate column is still in schema for new installs. We should remove it, and let contrib modules like modr8 hook_schema_alter() it back if they need to. No db_drop_field() since we don't want to lose data here and it's still in use in contrib.

Note this should have a tiny positive performance impact since won't need to maintain this index any more, which means slightly faster inserts.

CommentFileSizeAuthor
moderate.patch3.62 KBcatch

Comments

moshe weitzman’s picture

Status: Needs review » Reviewed & tested by the community

Makes sense.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Commited to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jbrauer’s picture

Status: Closed (fixed) » Needs work
Issue tags: +d7docs

Needs to be documented in the upgrade guide

webchick’s picture

Issue tags: -d7docs +Needs documentation

Thanks, Josh! Just FYI, this is the tag we've been using to signal that API changes haven't been reflected in the upgrade guide yet.

samuelsov’s picture

Status: Needs work » Fixed
Issue tags: -Needs documentation

Documentation updated here : http://drupal.org/update/modules/6/7#moderate_column

#d7csmtl

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.