I have found a couple problems in the user_relationship_blocks.module in a function that generates block titles.

1. The "My" in block titles that name a specific relationship type (such as "My friends" or "My professors"), is currently not run through the t function, and so cannot be translated.
2. The coding of the title generation function is perhaps overly complex, and unnecessarily runs some text through the t function more than once (first as component parts, and again as part of a larger concatenated string).

I have uploaded a patch as a possible solution that solves problem 1, and replaces the code described in problem 2 with a simple case statement.

CommentFileSizeAuthor
ur_blocks_xlate_fix.patch1.53 KBsja1

Comments

sja1’s picture

Status: Active » Needs review

forgot to set status... doh!

alex.k’s picture

Assigned: Unassigned » alex.k
Status: Needs review » Fixed

Thanks for the fix! Committed a different implementation with ifs (just trying not to do extra string manipulations if possible), also updated translations where I could, as a couple of these strings were not translated yet. http://drupal.org/cvs?commit=257976 http://drupal.org/cvs?commit=257998

sja1’s picture

No problem! Glad I was able to help.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.