Closed (fixed)
Project:
User Relationships
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
31 Aug 2009 at 16:15 UTC
Updated:
15 Sep 2009 at 08:50 UTC
I have found a couple problems in the user_relationship_blocks.module in a function that generates block titles.
1. The "My" in block titles that name a specific relationship type (such as "My friends" or "My professors"), is currently not run through the t function, and so cannot be translated.
2. The coding of the title generation function is perhaps overly complex, and unnecessarily runs some text through the t function more than once (first as component parts, and again as part of a larger concatenated string).
I have uploaded a patch as a possible solution that solves problem 1, and replaces the code described in problem 2 with a simple case statement.
| Comment | File | Size | Author |
|---|---|---|---|
| ur_blocks_xlate_fix.patch | 1.53 KB | sja1 |
Comments
Comment #1
sja1 commentedforgot to set status... doh!
Comment #2
alex.k commentedThanks for the fix! Committed a different implementation with ifs (just trying not to do extra string manipulations if possible), also updated translations where I could, as a couple of these strings were not translated yet. http://drupal.org/cvs?commit=257976 http://drupal.org/cvs?commit=257998
Comment #3
sja1 commentedNo problem! Glad I was able to help.