Tell #drupal about core cvs commits

killes@www.drop.org - August 31, 2009 - 16:37
Project:Bot
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:active
Description

no text

#1

webchick - September 1, 2009 - 22:34

No, thanks. I really don't want to get pinged every time I make a commit. :P That's very distracting when I'm trying to commit lots of stuff.

#2

webchick - September 1, 2009 - 22:35

Alternate ideas:

#drupal-commit-logs
#drupal-dev
etc.

But please don't spam me in #drupal.

#3

Morbus Iff - September 1, 2009 - 23:09

At the moment, I'm doing a cardinal sin and thinking about implementing a feature for one user: allowing the "seen ping prevention" code to be set on a per-feed basis. This would stop webchick's complaint (for CVS commit messages) and stop my complaint (for other feeds; if a feed items comes through and says "webchick sucks balls", webchick probably wants to be pinged about it).

However, this requires generalizing some code that is current embedded in bot_seen.module (to prevent a dependency) so may be a few days before I can implement it.

#4

webchick - September 2, 2009 - 00:08

I don't know that this is going to affect only one person. "Patch #xxxx by NICKNAME: whatever" is going to needlessly ping that person as well. Not to mention that the word "catch" in a commit message is needlessly going to ping catch. etc.

Why can't we just run all bot RSS feed output through the nice check username filter that seen messages use? Seems like it would be an easy fix.

#5

Morbus Iff - September 2, 2009 - 00:45

No, it won't - the only thing that is spit is the subject of the RSS feed item, which is always in the form of "Commit #123456 by [committer]". None of the description will be replicated in the message. And your last sentence is exactly what I just said in comment 3 ;) (though, it'd be on a per-feed basis, for the case scenario described above).

#6

webchick - September 2, 2009 - 00:52

Haha, sorry. It's very late here in Paris. :)

Thanks, Morbus.

#7

Michelle - September 3, 2009 - 01:04

I just found out about this because druplicon is currently spitting out every new forum post into #drupal-support. It's rather annoying when you're trying to have a conversation, especially at times when the posts are coming in quick. It had just spit out a block of 5 posts at once when I went and hunted down Morbus to see what was going on.

I really am -1 on any sort of automated spewing coming from druplicon into the normal conversation channels. The bot is very useful and I would hate to put it on ignore just because of that. If I'm in the minority, so be it, but I want to be on record that I think this is a bad idea. If someone wants to see every commit that goes through, can't we make an RSS feed for them? Ditto for forum posts. I like conversation on IRC, not automated reports.

Michelle

#8

Dave Reid - September 11, 2009 - 00:48

Cool idea, but I'm -1. :/

(07:44:17 PM) davereid: Twitter is perfect use for core CVS commit messages though. You're not forced to follow it or sign up for twitter if you don't want to know. But if you do, it's a handy way to know about them. It might be an interesting addition to #drupal, but I wouldn't want to be pinged. If we see the messages on #drupal, it's not optional and no avoiding it.
(07:46:45 PM) davereid: I'm saying it's a random message. The actual IRC message it would send for a CVS commit is not user-initiated. All the other bot commands are user-initiated.

#9

cweagans - October 14, 2009 - 01:10

I think it would be cool to see this in #drupal, but maybe like this:

Commit messages look like this

#12345 by so-and-so: message describing the commit

In #drupal, I think it would be nice to see something like this from Druplicon:

#12345: message describing the commit

As far as the user initiated thing goes, why not just use one of the commit hooks in CVS to tell the bot to send the message on IRC

Just my $0.02

#10

cafuego - November 12, 2009 - 22:23

What would actually be nice is if the bot were hooked into Triggers and/or Actions and/or Token, so that when an event occurred, it could post a tokenized string to an irc channel.

For instance, if the feed aggregator grabs 2 new messages from RSS feed X, post them to channel #foo-dev. Not necessarily commits, but also bug reports or other stuff. Or when a user posts a node, announce it on irc.

Adding that support may not necessarily be useful for Drupal devs themselves, but there are many open source projects that could benefit.

#11

snufkin - November 13, 2009 - 11:08

If you could write this up in a nice feature request and open a new issue, I can look into it, im interested.

#12

Morbus Iff - November 13, 2009 - 12:38

The only way that would work would be with http://drupal.org/node/239731 in.

But, I don't think aggregator actually has any hooks, to be listened to by Trigger?

 
 

Drupal is a registered trademark of Dries Buytaert.