fapi conversion - please check with care as this is my first fling at handling multiple submits.

1st draft methinks: handling the existing value in the basic search textfield still needs to be addressed properly. It is not the same as the current behaviour.

-K

CommentFileSizeAuthor
#20 search_box.patch_1.txt3.04 KBZen
#18 search_box_2.patch.txt3.22 KBZen
#16 search_box.patch_0.txt4.65 KBZen
#14 search_box.patch.txt4.97 KBZen
#12 fix_search_1.patch2.9 KBchx
#11 fix_search_0.patch2.42 KBchx
#8 fix_search.patch2.42 KBchx
#4 search.patch.txt750 bytesZen
#2 search_fapi_convert_5.patch.txt14.22 KBZen
#1 search_fapi_convert_4.patch.txt13.93 KBZen

Comments

Zen’s picture

Zen commented
StatusFileSize
new search_fapi_convert_4.patch.txt13.93 KB

.

Zen’s picture

Zen commented
StatusFileSize
new search_fapi_convert_5.patch.txt14.22 KB

This keeps existing functionality as is. Reviews appreciated :)

Thanks
-K

Steven’s picture

Steven commented
Status: Needs review » Fixed

Committed a modified version. The switch(TRUE) statement is IMO unnecessary obfuscation, while the checkbox handling can be compacted (use array_filter to keep only the checked ones).

Thanks.

Zen’s picture

Zen commented
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new search.patch.txt750 bytes

.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

applied

tenrapid’s picture

tenrapid commented
Status: Fixed » Needs work

The search box that can be displayed by some themes (e.g. bluemarine) is not working anymore. Phptemplate.engine calls search_box() (in system.module) to get the html for the box. It is displayed but after you click 'search' you are simply redirected to 'search/node'.

killes@www.drop.org’s picture

killes@www.drop.org commented
Priority: Normal » Critical

setting to critical, can't release RC1 without.

chx’s picture

chx commented
StatusFileSize
new fix_search.patch2.42 KB

Whao! This was badly broken.

chx’s picture

chx commented
Status: Needs work » Reviewed & tested by the community

and yes, I tested.

chx’s picture

chx commented

and yes, I tested.

chx’s picture

chx commented
StatusFileSize
new fix_search_0.patch2.42 KB

trimmed

chx’s picture

chx commented
StatusFileSize
new fix_search_1.patch2.9 KB

Even more fixes

chx’s picture

chx commented
Status: Reviewed & tested by the community » Fixed

committed by drumm

Zen’s picture

Zen commented
Priority: Critical » Normal
Status: Fixed » Active
StatusFileSize
new search_box.patch.txt4.97 KB
  • Move search_box to search.module from system.module - I don't know the reason why this was in system.module in the first place.. but moving it doesn't appear to break anything - turning the search module on and off; Toggling the theme's search box checkbox etc. If the search module is unavailable the checkbox is grayed out.
  • Currently, the three forms - search page form, theme search form and the search block form cannot coexist. Besides XHTML compliance issues due to duplicate IDs, the block form breaks on some pages due to the hook_form_alter adding in the advanced form. This patch addresses this.
  • Lastly, the CSS for the theme search box is broken and unnecessary in push button and bluemarine.. The text field and submit button are misaligned. This has been fixed by removing the relevant CSS from the style.css files for both themes.

The _submit functions could have been made more concise by using a callback, but as the theme function does not have a $form_id parameter, this couldn't be used. Accessing the form_id through $form seemed kludgy.

Thanks
-K

Zen’s picture

Zen commented
Category: task » bug
Status: Active » Needs review

.

Zen’s picture

Zen commented
StatusFileSize
new search_box.patch_0.txt4.65 KB

.

Steven’s picture

Steven commented

Why remove styles such as the border? Only the vertical margins should be removed and/or changed...

Zen’s picture

Zen commented
StatusFileSize
new search_box_2.patch.txt3.22 KB

CSS issue: http://drupal.org/node/56915

The remaining (unchanged) is attached.

Thanks
-K

Zen’s picture

Zen commented

Also, the #ref issue is back : http://drupal.org/node/56911

I think it might be best to keep it separate from the current patch.. so leaving that open.

Thanks
-K

Zen’s picture

Zen commented
StatusFileSize
new search_box.patch_1.txt3.04 KB

Leaner.

-K

Steven’s picture

Steven commented
Status: Needs review » Fixed

Committed to HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)