Old version used to work with one string "There are images in this gallery.", but after upgrade to new one, I see lots of untranslated strings (There are 9 images in this gallery. There are 15 images in this gallery. There are 458 images in this gallery.) on my site.

Seems like incorrect usage of t() function in this case. Only strings should be t()'ed, or there should be a variable placeholder (such as 'There are %no_of_images images in this gallery.')

CommentFileSizeAuthor
#1 564614.image_gallery-fix-t-count.patch1.22 KBjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Fixed
StatusFileSize
new 564614.image_gallery-fix-t-count.patch1.22 KB

Thanks for reporting this!

I've gone one further and used format_plural, so it looks better when there's only 1 image too.

timurek’s picture

timurek commented

Thanks for the fix, works perfectly! :)

joachim’s picture

joachim commented

Great!
Thank you for trying it :)

Status: Fixed » Closed (fixed)
Issue tags: -image_gallery, -images in this gallery, -t()

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +image_gallery, +images in this gallery, +

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.