little bug in validate function

Posted by sinasquax on September 1, 2009 at 12:04pm

Issue Summary

Hello there is a small bug which disable validation if website is not in english :

on search_config.module at line 285,

replace :

if ($form_state['values']['form_id'] == 'search_admin_settings' && $form_state['values']['op'] == 'Save configuration') {

by :

if ($form_state['values']['form_id'] == 'search_admin_settings' && $form_state['values']['op'] == t('Save configuration')) {

Comments

#1

Posted by dmitrit on November 6, 2009 at 1:13pm

Also re-index doesn't work:

 function search_config_validate($form, &$form_state) {
-  if ($form_state['values']['form_id'] == 'search_admin_settings' && $form_state['values']['op'] == 'Save configuration') {
+  if ($form_state['values']['form_id'] == 'search_admin_settings' && $form_state['values']['op'] == t('Re-index site')) {
+    drupal_goto('admin/settings/search/wipe');
+  }
+  elseif ($form_state['values']['form_id'] == 'search_admin_settings' && $form_state['values']['op'] == t('Save configuration')) {
     $post_values = $form_state['values'];
     $node_types = node_get_types('names');

#2

Posted by jweowu on December 14, 2009 at 11:57pm

Status:

active

» needs review

Attaching a patch for #1

Attachment	Size
565232-search_config.patch	785 bytes

#3

Posted by jweowu on December 15, 2009 at 12:08am

Status:

needs review

» reviewed & tested by the community

I'm going to mark this RTBC, as I've confirmed both of the fixes in dt_brume's solution, and my patch is identical to that.

#4

Posted by ckng on February 1, 2010 at 2:51am

Patch confirmed works for both problems.

#5

Posted by jbomb on February 25, 2010 at 3:17pm

Using drupal_goto could prevent other modules from performing validation. The following patch moves the validation function from hook_search() to hook_form_alter().

search_config-703322.patch