Currently, when adding a node via the add page type or the useredit type, pageroute looses the nid of the node. The following page shows the content right, but if you want to edit the node with the edit page type, it will allways create a new node instead of updating the existing one.

CommentFileSizeAuthor
#8 routepage_simpletests005.diff6.56 KBsepgil
#6 pageroute_passingNodes_003.diff712 bytessepgil
#3 pageroute_passingNodes_002.diff4.8 KBsepgil
#2 pageroute_passingNodes_001.diff4.57 KBsepgil

Comments

fago’s picture

fago
Primary language German
Location Vienna
commented
Issue tags: +pageroute-beta2
sepgil’s picture

sepgil commented
StatusFileSize
new pageroute_passingNodes_001.diff4.57 KB

This patch fixes the issue.

sepgil’s picture

sepgil commented
StatusFileSize
new pageroute_passingNodes_002.diff4.8 KB

A little piece of code is missing in my last patch. fixed it now

fago’s picture

fago
Primary language German
Location Vienna
commented
Title: passing nodes doesn't work properly » test passing nodes doesn't work properly works properly
Category: bug » task
Issue tags: -pageroute-beta2

thanks, committed.

However this looks to me as it could need a test, so it won't break again.

fago’s picture

fago
Primary language German
Location Vienna
commented
Title: test passing nodes doesn't work properly works properly » test passing nodes doesn't works properly
sepgil’s picture

sepgil commented
Status: Active » Needs review
StatusFileSize
new pageroute_passingNodes_003.diff712 bytes

Didn't worked for me anymore(I'm no sure why it worked before), so I a corrected it. Should work with this patch applied.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

ok, committed. still missing test -> setting back to needs work.

sepgil’s picture

sepgil commented
Assigned: Unassigned » sepgil
Status: Needs work » Needs review
StatusFileSize
new routepage_simpletests005.diff6.56 KB

I improved my simpletest so it tests this bug.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Reviewed & tested by the community

Looks fine! (Just did a visual review)

sepgil’s picture

sepgil commented
Status: Reviewed & tested by the community » Fixed

commited

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.