Thank you all for a great module, please keep up the good work!

I recently upgraded from 5.x-1.1 to 5.x-2.2 and ran into major problems. This site is on Drupal 5.12, and Token 5.x-1.11. I ran the update.php script, and I configured the new page title admin page.

When "show field" is turned on, and the page title field is filled in for a particular web page, then everything works fine. When [page-title] token is replaced with [title], everything works fine.

But when the page title field is enabled and NOT filled in for a particular web page, then I get errors. There are three types of errors:

- The word "Content" appears in place of the [page-title] token
- If the web page is in a menu, then its menu item title appears in place of the [page-title] token
- Especially for page views, a blank empty string appears in place of the [page-title] token

Please help.

Thanks,
Eric

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

I 90% sure this has to do with #264662: [page-title] can be wrongly replaced depending on whether and when token_replace() is executed by any other module.. Some reworking on the module committed on Revision 1.12.2.21 of page_title.module somehow restore back what that issue was attempting to fix. I think it has to do with it as the behavior is very similar to what I am experiencing and what I experienced back then when I reported that issue. I am thinking in bringing that issue back to life and hopefully provide a new patch for it, not sure why that was not taken into consideration on the new rework.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

Hi Eric, I am setting this one as a dupe of the issue i mentioned on my previous post. I have also brought that one back to life and submitted a patch for latest page_title version. If you can, can you try out that patch and see if that fixes your problem? It did for me. If it does, please comment back on that other issue instead of this one.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Active » Closed (duplicate)