Create a relationship "fan". User A is fan of B.

On the my relationship block for A it correctly shows fan of "B". But under "my relationship menu" it shows the reverse and shows "B Fan(them to you)" It should be "B Fan (You to them)

CommentFileSizeAuthor
#3 user_relationships.png83.05 KBnrackleff

Comments

alex.k’s picture

Status: Active » Closed (works as designed)

This is a tricky spot, as direction here is right or wrong depending on what the relationship means. But as there have not been any complaints on the wording so far, I would not change it for everyone.

ajayg’s picture

Status: Closed (works as designed) » Active

May be I was not clear.

I was not complaining about the wording per se. But would you agree this is a bug if the same wording shows "You to them" in both direction? whatever wording is, shouldn't that be different based on direction?

nrackleff’s picture

StatusFileSize
new83.05 KB

I am experiencing this same issue. We intended to use the module for creating 'friend' and 'follower' relationships. We set up a one-way relationship called 'follower'. I have two sample users, Ed Engineer and Deanna Drummer. I had 'Ed Engineer' click the link to become 'Deanna Drummers' follower. I would expect that to read as "You to them" in Ed's relationships page and "Them to you" on Deanna's relationships page, but the opposite is true. Also, if the relationship is only a one way relationship without required approval, shouldn't it be true that only the person who created it would have access to delete it? Instead, Deanna also sees a 'remove' link. See attached screen shot showing both users' relationship lists.

wendelj’s picture

I'm seeing the same issue with one way relationships showing the incorrect direction on the relationships > all page but the correct direction when you click on the person you have a relationship with.
In "user_relationships/user_relationships_ui/templates/user_relationships.tpl.php" I changed line 14 to fix this problem.

Original:
$relationship->name . ($relationship->is_oneway ? ($this_user_str == 'requester' ? t(' (You to Them)') : t(' (Them to You)')) : NULL),

Fixed:
$relationship->name . ($relationship->is_oneway ? ($this_user_str == 'requester' ? t(' (Them to You)') : t(' (You to Them)')) : NULL),

alex.k’s picture

Assigned: Unassigned » alex.k
Status: Active » Fixed
Issue tags: +rc3block

Thank you all for catching this. Committed a slightly different fix, http://drupal.org/cvs?commit=262456.

dankoB’s picture

Thanks for making this great module. I struggled with those one-way relationships a bit before realizing the mixup.

I'm new to this, so I'm not sure where to review your solution. It seems to me that although the faster and simpler solution is to switch it such that the default relationship is "Me to Them", it makes more sense that when you are viewing someone that you think of the relationship as how that person is related to you -- so the default should be "Them to Me".

I am setting up a site for families with parents and children. If I am logged in and looking at a list of users, and I see my kids there, then I would think that my view of that relationship is "child" or Them to Me. Then in Views, when I make a gallery of "My Kids", I filter by the relationship "child". Accounting for these one way relationships instead of the usual mutual "Friends" means several of UI wordings could be better, to accommodate the forward vs back assumptions. A statement like "Are you sure you have a child relationship with ___?" is ambiguous. Clearer would be "Are you sure ___ is your child?" Or depending on the direction chosen, "Please confirm that ___ is your ___" vs "Please confirm that you are ____'s _____." It would also be good to change phrases like "No friends added yet" to "No relationships added yet." Many phrases like "Accept ____ request" may be better as "Confirm your _____ relationship to ____. "

alex.k’s picture

To test and use the fix, please just download the latest 6.x-1.x-dev release and run through update.php on your site.

As far as changing wording - actually, this is a pretty common customization when building a site. You can change any strings by using the string overrides module http://drupal.org/project/stringoverrides

You just need to use the exact string the module passes to t(), for example "Become %name's %rel_name" or "This user has requested to be your %relationship_name. (!pending_requests)" - you can get these from the module code or by searching at admin/build/translate/search.

dankoB’s picture

Thanks for the followup. The string overrides work well.

Status: Fixed » Closed (fixed)
Issue tags: -rc3block

Automatically closed -- issue fixed for 2 weeks with no activity.