maozet [maozet]

Remember to change the status of the report, when you upload new code for the review; differently, the reviewers cannot know if there is code to be review.

1. Theme names (as well as module names) must not start with a number.
2. The line containing version = "6.x-1.1" needs to be removed, as it is added by the packaging script.

There are surely two themes which contain numbers as first characters, but the short name of the project doesn't contain numbers as first characters; the themes are 960 Robots, and 960.gs Fluid, and 960 is a reference to the framework 960.gs.

The attachment link is http://drupal.org/files/issues; it doesn't take to any file.

See my comment about what is a correct name for a theme (both the short, and the normal name).

I use a font that has an O similar to a 0.
In this case, the theme name is acceptable.

1. Some files miss the CVS ID tag.
2. In some cases, the indentation is not correct (it passes from 0 to 4).

1. name = 0deta
   description = 0deta theme is ideal for blogs and community sites. Includes 5 flexible content regions(more to come). By <a href="http://www.drupaldir.com">DrupalDir.com</a>. Based on <a href="http://www.askgraphics.com/freetemplates/transblack-wordpress-theme-released/">transblack</a> theme
   

   The reported name is not correct (it begins with a zero).

2. 					<div id="menu_search_box">
   					 <?php if ($search_box) { ?>
   					 	<div id="search-box">
   							<?php print $search_box; ?>
   						
   						</div><!-- /search-box -->
   					<?php } ?>
   
   

   The indentation should be of two spaces, not tabs. The IF-statement could use the alternative syntax, which has been already used in other part of the code.

3. 				<?php if (0 && $breadcrumb): ?>
   				<div id="breadcrumb">
   				<?php print $breadcrumb; ?>
   				</div><!-- /breadcrumb -->
                                   <?php endif; ?>
   
   

   The indentation is still incorrect.
   What is the result of if (0 && $breadcrumb)?

4.   $vars['logged_in'] = ($user->uid > 0) ? TRUE : FALSE;
   

   The code can be simply written as $vars['logged_in'] = ($user->uid > 0).

5. 	$body_classes = array();
   	$body_classes[] = ($vars['logged_in']) ? 'logged-in' : 'not-logged-in';// Page useris logged in
   	$body_classes[] = ($vars['is_front']) ? 'front' : 'not-front';      // Page is ront page
   	$body_classes[] = ($vars['search_box']) ? 'search' : 'search_no';
   
   	$body_classes = array_filter($body_classes); // Remove empty elements
   

   Which empty elements should the code remove?

6. function phptemplate_preprocess_search_theme_form(&$vars, $hook) {
   	//print_r($vars);
   	// Modify elements of the search form
   	$vars['form']['search_theme_form']['#title'] = t('');
   

   What is the Chinese translation of an empty string?

7. 	$vars['form']['search_theme_form']['#attributes'] = array('class' => t('txtSearch s'),
   

   CSS class names are not supposed to be translated.

I still see tabs, but that is a minor detail.