Hi,

I'm using Node Hierarchy and Link Checker on my multilingual website. If I turn on automatic updates of redirected (301) links, Link Checker will create a new revision (good), the link will be updated (good), but the Node Hierarchy information (i.e. Parent Node) will be lost.

It's problematic since it can make nodes "disappear" from the website if we rely on Node Hierarchy to display the structure.

CommentFileSizeAuthor
#3 before update.png5.69 KBmdupont
#3 after update.png5.42 KBmdupont

Comments

hass’s picture

hass commented
Status: Active » Postponed (maintainer needs more info)

Do you know how Node Hierarchy works? Otherwise I need to review if Node Hierarchy does some strange - non API things... Please explain how to repro... I never used Node Hierarchy nor have an idea how to config... maybe easy... but I do not know it.

hass’s picture

hass commented

Aside - do you know what "breaks" if we look on the raw data?

mdupont’s picture

mdupont
Primary language French
Location Switzerland
commented
StatusFileSize
new after update.png5.42 KB
new before update.png5.69 KB

Node Hierarchy allows to have a hierarchical node structure by specifying a parent node for any given node. So you can have "the node 'Drupal' has the node 'CMS' as a parent".
From what I know, Node Hierarchy creates a new database table with 2 columns : 1 for the nid of the source node, and 1 for the nid of the parent node. This information is revision independant ; it is attached to the node, not to the revision.

To reproduce, just have Node Hierarchy enabled, one or more nodes with parents and sporting a link to a 301 redirect, and Link Checker set up to update 301 redirected links automatically. When Link Checker updates the content to fix the link, it will create a new revision with "Anonymous" as a user. Strangely, all nodes that will be processed by Link Checker will no longer have a parent node. I had this problem with 15 or so nodes that were updated last night by Link Checker.

In the attached screenshots (from the editing interface) you can see how the parent node information is affected.

The issue could also come from Node Hierarchy's management of updates, i'll fill an issue there too.

hass’s picture

hass commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

I believe that the node hierarchy is the source of this issue. linkchecker only loads the node, change the link and save it back. If node hierarchy does not keep their fields... what should I do there? It sounds like a bug in the nodeapi hook.

For now I would better disable the auto update on your site until it's investigated further.

Please do not duplicate issues... we can move an issue between projects. Marking as a duplicate of #566354: Node hierarchy lost if other modules load/update nodes.