The Admin module (http://drupal.org/project/admin) modifies the fieldsets blocks on the admin/modules page to use divs and h2s instead of fieldsets and legends which breaks the 'Expand all | Collapse all' links which are looking for collapsible fieldsets and not divs.

Comments

robinhodrup’s picture

robinhodrup commented

Hi there,

I'm not sure if this is me getting the wrong idea as I'm currently testing Drupal for the organisation I work for. Anyhow, I have a number of fieldsets to collapse in blocks which allow users to collapse/view different peices of content from the front page. I was going to put together something myself which saved the state of these to a cookie, but then I stumbled across this plugin. I've installed it but it doesn't save the collapse state of the blocks. Do I indeed have the wrong idea, or should this in fact be working in this way.

Regards,

R.

jrockowitz’s picture

jrockowitz commented

As long as you are using Drupal's collapsible fieldset you can just add the required javascript. #628322: Manually creating a fieldset?

Something I have realized while using my own module is the 'state manager' should probably be isolated into a new API so that it can be used to save the state for any client/server-side element in Drupal.

If you are still having problems. Feel free to post the code snippet for your blocks.

robinhodrup’s picture

robinhodrup commented

just sorted it thanks!

jrockowitz’s picture

jrockowitz commented
Status: Active » Closed (won't fix)

Right now, this issue is extremely difficult to fix due to how the admin.module, more specifically the rubik.theme, overrides the fieldset theme function. For now an "in-compatibility" warning has been added to 6.x-2.x-dev branch.

jrockowitz’s picture

jrockowitz commented
Status: Closed (won't fix) » Needs review

Strike that...

Support for the Rubik theme (http://drupal.org/project/rubik) and Tao theme (http://drupal.org/project/tao) has been addressed in the 6.x-2.x-dev branch.

mrP’s picture

mrP commented
Version: 6.x-1.x-dev » 6.x-2.x-dev

Just tried with fieldset_helper-6.x-2.x-dev and rubik-3.0-beta2 + tao-6.x-3.2 and couldn't get expand all to work. Did you have to do anything else to make this work?

UPDATE: upon further inspection, its definitely an issue with rubik specifically. with tao set as administration theme, expand all function works as expected.

mrP’s picture

mrP commented
Status: Needs review » Fixed

Tested on a fresh drupal install and rubik + fiieldset_helper expand all functions works.

Previous post was regarding a sandbox install with a lot of rubbish...

jrockowitz’s picture

jrockowitz commented

Boy... this is tricky one, because I went in a reviewed the current code and saw a very minor bug that was breaking the collapse all in rubik on just the modules page.

For now I will leave this issue closed but if anyone has the same problem please feel free to re-open it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.