Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.With blogtitle installed, if no profile field is specified at admin/settings/blogtitle, then the titles of users' blogs become empty, rather than the default "[user]'s blog".
The same thing happens if a profile field is specified, but a particular user doesn't specify a blog title in their profile. Again instead of the default "[user]'s blog", they get an empty blog title.
The problem is that blogtitle_get_blog_title(), in blogtitle.module, never uses its $default argument, always returning false instead. The attached patch corrects this problem.
Thanks,
Andrew.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | blogtitle-6.x-1.2-dev-3-unofficial.tar_.gz | 8.52 KB | Andrew Schulman |
| #9 | capture_06112009_163143.png | 40.23 KB | marcushenningsen |
| #8 | blogtitle-6.x-1.2-dev-2-unofficial.tar_.gz | 8.52 KB | Andrew Schulman |
| #7 | capture_06112009_020551.png | 32.16 KB | marcushenningsen |
| #6 | blogtitle-6.x-1.2-dev-1-unofficial.tar_.gz | 8.5 KB | Andrew Schulman |
Comments
Comment #1
remi commentedThanks for patch, Andrew! I will merge it with the code and post a new release as soon as possible.
Comment #2
Andrew Schulman commentedOK. Might want to wait on the new release as I have another bug report + patch coming shortly.
Comment #3
remi commentedNo problem. I'll wait.
Comment #4
ashtonium commentedtested the patch, looks good. Please apply to 6.x-1.x-dev if you're waiting to roll a point release, thanks.
Comment #5
marcushenningsen commentedThanks for the patch.
Andrew: I'm experiencing some problems when I apply all your patches. May I suggest a complete patch against the current version of the module. Or even better, a dev-version of the module with your patches (or at least some of them) committed.
I'm very eager to test and give feedback, but I'm finding it hard to know where to start.
Marcus
Comment #6
Andrew Schulman commentedMarcus, here's my unofficial -dev release, if you like. To make it I started with blogtitle-6.x-1.2, and applied the patches posted at the following issues, in order:
I did have to revise the last of those, because it apparently was created against a non-clean version of blogtitle. Sorry. I've posted the revised patch with that issue. That may be why you were having trouble, or it may be because the patches listed above have to be applied in the above order.
The other outstanding patch that I didn't apply here is astonium's in #609982: title isn't replaced in breadcrumbs. I didn't apply that one to this build because I haven't reviewed it and it seems that it may not be ready yet. You might be able to apply it to this unofficial build.
So, try it out, and report your results on the individual issues.
Andrew.
Comment #7
marcushenningsen commentedThanks for this. I've tested your unofficial dev-release, and I'm experiencing some problems. I'll try to address them in the order of patches:
Blog title
The default blog title is not shown correctly. A user named 'Bo' has this title shown:
<a href="/users/bo" title="Vis brugerprofil.">Bo</a>'s blog. Somehow the username is shown as a link to the user's account (but not rendered).Blog link
The same as above happens with the links; the link for Bo's blog outputs
<a href="/users/bo" title="Vis brugerprofil.">Bo</a>'s blog.In addition to that the title turns up twice in the links, one is rendered as a link, the other not. I'v attached a screenshot to show this.
Realname
Sorry, not using realname right now, so I didn't test this part.
Breadcrumb
I also tested this patch separately: Works only for non-defealt, if default nothing is outputted.
Though I don't think it relates to this patch, there's also an inconsistency of breadcrumb naming: When I'm viewing a blog post the breadcrumb shows my the corresponding blog name (e.g. Bo's blog) but when I'm viewing the landing page for the blog ( i.e. blog/[uid] ) the breadcrumb outputs "My blog". I'm not logged in as Bo. Is this behaviour to be changed?
Marcus
Comment #8
Andrew Schulman commentedWhoops. OK, thanks for finding that. I've posted a revised patch at #566610: blogtitle and realname are incompatible that fixes that error.
remi: the latest patch at #566610 also fixes this bug, so the patch in my original report here is no longer needed if you apply that one.
Here's a revised unofficial -dev tarball. It applies the latest patches from #566610: blogtitle and realname are incompatible and #610164: title isn't replaced in blog link in nodes, and fixes this bug as well.
Comment #9
marcushenningsen commentedLooks good, thanks for this. The titles and the links are good.
Still I have a couple of issues.
The link shows the blog title correctly, but the module also outputs the blog title as a term, even though there is no vocubulary or term existing with these names. Check the screenshot. The problem is isolated to this module.
What's your status on the breadcrumb patch, were you going to revise that as well? Whenever you feel it's ready, I'd love to test that as well.
Marcus
Comment #10
Andrew Schulman commentedCorrect me if I'm wrong, but that sounds like a separate issue from this one. If so you should submit a new issue report for it.
The patch I originally submitted with that report was wrong. astonium submitted another patch using a different approach, but I haven't had time to look at or test it yet.
Let's move any further discussion of that issue over to its issue report.
Comment #11
marcushenningsen commentedI'm not sure, it seems isolated to this module, if I remove the module, the problem goes away. Somehow the blog title gets printed both in the node's links and node's terms.
I agree. I'll test and report back.
Comment #12
Andrew Schulman commentedSame module, but a different issue. This issue concerns an empty blog title. You should open a new issue report about that problem.
Comment #13
marcushenningsen commentedYou're right, however, the problem is that this issue only applies to your unofficial dev-release, so opening a new wouldn't really be fair.
Comment #14
Andrew Schulman commentedI see. Well in that case, I think one of us is going to have to figure out which of the two patches I applied-- from #566610 or #610164-- is the cause of the problem. I'm guessing it's the 2nd. I'll look at it when I can.
Comment #15
marcushenningsen commentedYou're right, it's #610164. I'll try to look into this right away and report back.
Comment #16
Andrew Schulman commentedGood, thanks. Please do that as a follow-up to #610164, since this whole discussion is OT for this bug.
Comment #17
Andrew Schulman commentedHere's a revised unofficial -dev build, starting from blogtitle-6.x-1.2 and incorporating the following patches:
Comment #18
marcushenningsen commentedI've installed the above unofficial version, and everything seems to work. I recommend that it gets committed and that I new official version is released. What's the maintainer's opinion?
Marcus
Comment #19
remi commentedHi everyone,
First of all, thank you to everyone who helped fixed the bugs in this module and review the patches. I really appreciate this. I've recently moved in Japan and just moved in my new apartment this week, so I haven't got time to maintain my Drupal projects recently. Hopefully, I'll be able to commit a new version of the module this month. Thank you for your patience!
Rémi
Comment #20
remi commentedThank you for your work! The patch files have been committed to version 1.3.
Comment #21
remi commented