Why does the Number markers set start with number0.png? From a usability standpoint a user is not going to understand why the first item says "0". Additionally, even Views uses "1" as the first item when you display the "Global: View result counter" field.

CommentFileSizeAuthor
#1 gmap-n566420.patch1.11 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new gmap-n566420.patch1.11 KB

A quick patch to change the number.ini file to start with "number1.png" instead of "number0.png". The patch doesn't indicate that the number0.png file should also be removed.

Matt Townsend’s picture

Matt Townsend commented

This patch seems to work for me.

I don't think the map numbers should start at zero, unless there is a compelling technical reason. Most end users are going to be confused by that.

jcmarco’s picture

jcmarco commented

It works fine.
Just outline that is needed to regenerate markers from the gmap setting page.
Views order numbers start at 1 so there should be some coherence with this.

Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-1.1-rc1 » 6.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

+1 to commit this. This is plain silly, anybody who really want's it to start at zero will probably find great joy in hacking it back.

rooby’s picture

rooby commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch.

Committed to 5, 6 & 7.

http://drupal.org/cvs?commit=379174
http://drupal.org/cvs?commit=379170
http://drupal.org/cvs?commit=379172

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.