Posted by pp on September 2, 2009 at 9:48pm
4 followers
Jump to:
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | base system |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (duplicate) |
Issue Summary
There is an issue #510094: Add description to the link items of the toolbar. There is a accessibility problem. I think this problem need to be solved globally whit fixing the l() function.
Please review my patch after you read Everett Zufelt's comment[#510094-12]
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| accessibility-title.patch | 1.44 KB | Idle | Failed: 12768 passes, 18 fails, 0 exceptions | View details | Re-test |
Comments
#1
The last submitted patch failed testing.
#2
@PP
From what I see in your patch it looks like you are testing to see if the title attribute has been set in the $options array passed to l() and then using
<span class="element-invisible"></span>to hide the title as part of the link text.This isn't necessarily a bad approach, it means that a screen-reader user would have access to the title attribute all of the time. However, I wonder with how prevalently the title attribute is used on links for non-important text in drupal if this would really be a useful general practice?
#3
I don't think this really can be generalized like this.
Probably worth discussing in G.D.O -> http://groups.drupal.org/accessibility
I do think it's worth while focusing on a few specific elements first and ensure that they are adding more useful context for all visitors.
Also worth seeing:
#526712: l() does not accept a parameter for supplemental text for screen-readers
#49428: Include node title in "Read more" link for better accessibility and SEO
#4
Marking this issue as a duplicate of #526712: l() does not accept a parameter for supplemental text for screen-readers. Each issue has pointed out that there is a need to embed invisible text, for screen-reader users, within some links and has suggested the approach of modifying l() to provide this functionality. This approach was deemed to be inappropriate in the prior mentioned issue.