Paging has become nonfunctional after upgrade from 5.x-1.0 to 5.x-1.2.
pdxhayes - September 2, 2009 - 23:18
| Project: | Paging |
| Version: | 5.x-1.2 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | active |
Description
Paging has become nonfunctional after upgrade from 5.x-1.0 to 5.x-1.2.
I updated the paging module for an existing drupal 5.19 production deployment that was using paging 5.x-1.0. After update, paging is no longer active.
I have confirmed the following:
1) The paging module is enabled
2) The appropriate node types are selected in the paging settings
3) The input format filters have paging enabled
4) The node content has appropriate pagebreaks
Paging however, is not visible.
I apologize if I missed some note or detail in my research about upgrading the module, however I have found no solutions after an exhaustive search.
#1
#2
This happened to my sites too, causing huge problems with long content that had pagebreak tags carefully inserted at ideal positions. It was all working with Paging 5.x-1.0 but not with 5.x-1.2.
Paging based on character count works, so I wonder if the module is not working as documented. It's supposed to use a pagebreak tag if it exists in the node's body, otherwise use the character count (if enabled) to add page breaks. I suspect that it always uses the character count even if pagebreak tags exist -- AKA, a bug.
#3
Update: Paging based on characters doesn't work reliably either, so we've had to disable this module.
Paging based on characters breaks bullet lists, which causes formatting problems. On the page where the bullet list is continued, the starting tag UL or OL gets left behind on the previous page. All we have are LI tagged lines, which therefore get a bullet symbol but none of the appropriate formatting.
Also, there are other situations where we get odd formatting in the first paragraph of the next page, not clear why. One situation is when the page splits mid-paragraph, leaving the P tag on the first page, but not putting it on the next page, therefore whatever formatting it carries (usually via CSS) is ignored.
The resulting bad formatting is simply not acceptable on a professional site, so this module can't be used.
#4
I'm not sure how "correct" this patch is, but it fixed the problem for me.
In the 1.0 version of this module, all the manipulation of the node body was done in hook_nodeapi under op = view, and what was being manipulated was $node->content['body']['#value']. In the 1.2 version of this module all the manipulation happens under op = alter, and upon $node->body instead. $node->body then had the correct value, but $node->content['body]['#value'] was still being output. I added this one line (@ ln 255) and now the pagers reappeared on my site.
$node->content['body']['#value'] = $node->body;Please review.
#5
jenlampton - your patch got paging back - but I was getting broken tags appearing: p> at the top of pages - so I've downgraded back to 5.x-1.0 until this is fixed.