theme settings is not worked [#56713]

in my themes template.php file:

function phptemplate_settings(){
	$settings = variable_get( 'theme_esjing_settings', array());	
	$form['foo'] = array('#type'=>'textfield','#default_value'=>$settings['foo']);
	return $form;
}

the function phptemplate_settings is neved called on admin/themes/settings/esjing .
or am i wrong?

Comment	File	Size	Author
	patch_17.txt	618 bytes	oscnet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

oscnet CreditAttribution: oscnet commented 31 March 2006 at 15:46

Status:

Active

» Needs review

patch worked for me.

Comment #2

oscnet CreditAttribution: oscnet commented 4 April 2006 at 02:29

http://drupal.org/node/49703

Comment #3

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 6 April 2006 at 18:17

Status:

Needs review

» Fixed

applied

Comment #4

Heine CreditAttribution: Heine commented 11 April 2006 at 16:28

Status:

Fixed

» Active

Sorry to reopen,

The patch doesn't work when you're not editing settings of the active theme; unfortunately a new issue was opened http://drupal.org/node/57676.

I also think it should be a feature request, not a bug-report; it seems that 'engine'-themes only support engine-specific settings, not theme specific settings.