Hi,
thanks for that fine module - I like to use it very much!

I do not understand this behaviour, that when I open new messages they will still displayed as "new". I think, they should automatically be marked as read after I opened them.
What do you think?

Best regards, Ralf

CommentFileSizeAuthor
#5 mark_read_bug.patch735 bytesberdir

Comments

naheemsays’s picture

they ARE marked as read after the first time you open them, are they not?

Refresh the page and you will see the "new" markup disappear.

berdir’s picture

There was a related bug, that should be fixed in rc3 I think.. if not, it should be fixeded in the latest dev release.

R.Hendel’s picture

@nbz:
This happens in context with organic groups, when the owner of a new group gets notifications, that he is administrator. These notification mails habe the exception, that they have no other recipients beneath sender - maybe this has something to do with that behaviour?

Plazmus’s picture

I have latest dev version from 5th Oct and it looks like this bug is still there.

If I manually do "Mark as read" and then "Mark as unread" and then when I open message it's automatically marked as read.

berdir’s picture

Status: Active » Needs review
StatusFileSize
new735 bytes

I assume there is still duplicated data generated somehow or still in the database.

Just wondering, are you using other modules that interact with privatemsg (by sending private messages, for example). I *thought* we fixed that bug.

Can you try the attached patch?

berdir’s picture

See #600812: inbox could be list with received messages only. I think this happens because of a wrong check that does have to do with the read all permission. I'm leaving this open because it might still make sense to commit this patch too to avoid bugs with this in the future and existing data.

angelmax’s picture

Hello,
I am using rc3 and very randomly I have the same issue. usually they are messages automatically generated as a notification of new comments to posts.

Can somebody tell me if this has been fixed in DEV and if it is SAFE to move from rc3 to dev in a production server?

thanks.
AM

Plazmus’s picture

I installed latest dev version and messages are automatically marked as read, yeah!

naheemsays’s picture

@ #7 = what is generating the notification messages? Maybe the pai is being used incorrectly?

also, is this fixed by #600812: inbox could be list with received messages only ?

igorik’s picture

Status: Needs review » Reviewed & tested by the community

@nbz I can confirm that it is fixed with #600812: inbox could be list with received messages only
and with latest dev it works like a charm

berdir’s picture

Now I am confused ;)

If it is fixed, why do you set this issue to RTBC? ;)

Also, am I assuming correctly that is only fixed for new messages, currently existing messages that can't be marked are still broken? While the inbox bug can't be fixed for existing data, this probably can, we already did once.

angelmax’s picture

@ #9 : I am not sure but should be the Notification module notifying about new comments, using privateMsg.

igorik’s picture

#11 @Berdir
i though that decision if the issue is fixed do module mantainers. So i only set it that it is reviewed an wrote that it works.

berdir’s picture

Status: Reviewed & tested by the community » Fixed
i though that decision if the issue is fixed do module mantainers. So i only set it that it is reviewed an wrote that it works.

If a patch has been commited, yes. But for example for support requests, the person who asked should set the issue to fixed since we can't tell if it has been answered or not. The status "reviewed & tested by the community" should only be chosen if you have extensively tested the patch of an issue and think that it should be commited.

I'm setting this to fixed since the bug is fixed and we do now have tests to verify that this does not happen again. So the additional order by in the above patch shouldn't be necessary anymore.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tanu487’s picture

Component: User interface » Code
Issue tags: +messages, +mark

When marked as read/unread, the page redirects to the search page. Please put some light on this..