Posted by Scott Reynolds on September 3, 2009 at 5:37pm
| Project: | Smackdown |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
This is sortof it
Kindof :-D
Just not a fan of $_SESSION stuff. Particularly if its just supposed to carry through to the next page.
I think the bug will show up if you vote on the last, land on the results page and then go somewhere else. And finally end up at a smackdown node. But even then is it a bug? /me shrugs
| Attachment | Size |
|---|---|
| session.patch | 1.91 KB |
Comments
#1
this is a really clean approach. It replaces the redirection (die non-theme theme functions! :-D ), with a drupal_alter() and adds the location to the response, via url() (YA! path alias') with a query.
Pretty slick, and pretty clean. I figured other modules would like to modify the vote, or react to the vote differently changing the location. All cool achievable things.
#2
bah! i really wish i could submit a patch once correctly...
This one removes the erroneous $_SESSION[] for the node_load().
#3
committed http://drupal.org/cvs?commit=278840
#4
Automatically closed -- issue fixed for 2 weeks with no activity.