This is sortof it

Kindof :-D

Just not a fan of $_SESSION stuff. Particularly if its just supposed to carry through to the next page.

I think the bug will show up if you vote on the last, land on the results page and then go somewhere else. And finally end up at a smackdown node. But even then is it a bug? /me shrugs

CommentFileSizeAuthor
#2 smackdown_get.patch2.98 KBScott Reynolds
#1 smackdown_get.patch2.89 KBScott Reynolds
session.patch1.91 KBScott Reynolds

Comments

Scott Reynolds’s picture

Scott Reynolds commented
Status: Needs work » Needs review
StatusFileSize
new smackdown_get.patch2.89 KB

this is a really clean approach. It replaces the redirection (die non-theme theme functions! :-D ), with a drupal_alter() and adds the location to the response, via url() (YA! path alias') with a query.

Pretty slick, and pretty clean. I figured other modules would like to modify the vote, or react to the vote differently changing the location. All cool achievable things.

Scott Reynolds’s picture

Scott Reynolds commented
StatusFileSize
new smackdown_get.patch2.98 KB

bah! i really wish i could submit a patch once correctly...

This one removes the erroneous $_SESSION[] for the node_load().

sirkitree’s picture

sirkitree commented
Status: Needs review » Fixed

committed http://drupal.org/cvs?commit=278840

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.