Firstly, let me say this is a great module to have, well done emackn!

But onto the point of this post: it seems the aliases that get generated ignore the pathauto setting "Character case: Change to lower case". Looking over the code, the views_alias module rightly relies on the pathauto_cleanstring() to get the clean term value, but for some reason this function doesn't run any of the case conversion stuff (looks like it gets done in pathauto_create_alias() though).

So is this a pathauto or a views_alias bug? Whatever the case for now, I've written a little patch for views_alias (will attach in next post with correct issue number).

CommentFileSizeAuthor
#2 view_alias-lowercase-568026.patch505 bytesquicksketch
#1 view_alias-568026.patch732 bytesalexkb

Comments

alexkb’s picture

alexkb commented
StatusFileSize
new view_alias-568026.patch732 bytes
quicksketch’s picture

quicksketch
he/him
commented
Title: aliases created with wrong case setting » Aliases created with wrong case setting
Status: Active » Needs review
StatusFileSize
new view_alias-lowercase-568026.patch505 bytes

Thanks for the patch alexkb, I don't think this is a problem with Pathauto, since it actually does something very, very similar in pathauto_create_alias():

  if (variable_get('pathauto_case', 1)) {
    $alias = drupal_strtolower($alias);
  }

This brought to my attention that your patch uses the wrong default value, it should be 1 instead of 0. Here's a revised patch with that change.

emackn’s picture

emackn commented

I refactored the view_alias_pathauto_bulkupdate() function, so i'm not sure if the patch is still needed. Check out lastest beta or HEAD to see if you are still having trouble.

emackn’s picture

emackn commented
Status: Needs review » Postponed (maintainer needs more info)
quicksketch’s picture

quicksketch
he/him
commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

Let's consolidate this with #652780: Aliases not updated when terms are updated/deleted, which also fixes this problem by having Pathauto create the aliases for us.