If I revert to a previous revision a node which is defined as a section it loses it's section designation.
The mlid and nid disappear from all the menu_node tables.

CommentFileSizeAuthor
#4 568246-revision.patch611 bytesagentrickard

Comments

agentrickard’s picture

Ugh. That is probably a form action that we do not account for.

Does the revision reversion process not fire hook_nodeapi()?

agentrickard’s picture

I bet the node_save() in node_revision_submit_confirm() doesn't pass the menu data like the regular node edit form does. Looks like we have to change our save routine.

One question, though, are menu assignments stores as revisions? Is it possible that the previous revision was not in a menu?

agentrickard’s picture

Project: Menu Node Edit » Menu Node API
Version: 6.x-1.6 » 6.x-1.2

Oh, this would actually be a Menu Node API bug.

agentrickard’s picture

Status: Active » Needs review
StatusFileSize
new611 bytes

Here's a patch to try. This is crying out for SimpleTests.

The patch works by doing nothing if the $mlid is not present.

agentrickard’s picture

Status: Needs review » Fixed

Committed to HEAD and released as 6.x.1.3.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.