Comments

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

snlnz’s picture

Title: Able to bypass validation on payment amount » syntax error on line 291:
Issue tags: +uc_migs, +ANZ, +eGate

Current server config: Drupal 6.15/MySQL 5.0.45/PHP 5.2.9/Ubercart 2.0 + a lot of modules

in uc_migs.module breaks after update to 6.x-1.x-dev:

Line: 291
$items[] = t('Transaction Response Code Description: !description', array('!description'=>_uc_migs_uc_migs_get_response_description($txnResponseCode)));

Needs to be:

$items[] = t('Transaction Response: !description', array('!description'=>_uc_migs_get_response_description($txnResponseCode)));

Also, ANZ Integration Support don't accept the following:
Line: 329
case "1" : $result = "Unknown Error"; break;

Should be changed to:
case "1" : $result = "Transaction could not be processed"; break;

Finally, ANZ will not approve the following (as per the dollar amount .10 test - Transaction could not be processed) requirement
$items[] = t('Message: !message', array('!message'=>$message));
$items[] = t('Transaction Response Code: !code', array('!code'=>$txnResponseCode));

so you must comment them out like this:
//$items[] = t('Message: !message', array('!message'=>$message));
//$items[] = t('Transaction Response Code: !code', array('!code'=>$txnResponseCode));

A nice to add for your payment page is on:
Line: 69
$title .= '
Only local images are allowed.';

by default this line is commented out and makes the page look very basic. At least this gives you the ANZ icon with the TM as per requirements.

TODO:
test the validation functionality
confirm acceptance from ANZ
follow up report.

Hope this is helpful.

xurizaemon’s picture

Title: syntax error on line 291: » Able to bypass validation on payment amount

Resetting issue details which had been inadvertently altered by Karu's previous comment.

Karu, I've fixed the _uc_migs_uc_migs_get_response_description() issue, thanks for letting me know about that.

Note that reporting bugs by adding a comment to an already closed ticket is a sure way for your issue to never be looked at. And threadjacking a live issue is just asking for trouble ;)

I would really appreciate it if you re-post any remaining issues as NEW issue(s) by following this link: http://drupal.org/node/add/project-issue/uc_migs

Thanks again.