file directory location
indytechcook - September 4, 2009 - 16:43
| Project: | SimpleTest |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | boombatower |
| Status: | closed |
Description
First, thanks for a great module.
I have a questions about the use if "file_directory_path()" as the "originalFileDirecotry" and it's use in DrupalWebTestCase->drupalGetTestFile.
This points to the sites 'files/simpletest' directory. Since the copying of the files could fail in the module install (like mine did), I propose that we add a check to see if the file exists. If it doesn't, check the drupal_get_path('module', 'simpletest') . '/files' location. Otherwise you get alot of failure in many different simpletest module scripts, including imagefield and fieldfield.
I'm attaching a patch for this.
#1
Attaching patch.
#2
setting to needs review.
#3
Perhaps we should just make a failure message during install?
#4
Also, how does it fail. If it has write access and all it should work?
#5
It failed during the install profile. I'm not exactly sure how it failed. I'll step through with the debugger.
I had first thought about giving the ability to specify a file location which could be useful for other modules.
That is a very good question. I didn't find any good reason why it failed, my only thought is that it had something to do with the install profile.
#6
Please re-open if you have more details.