Here is the Warnings we received upon trying to update Image module on Drupal 6 site:

* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'All' tab, access 'I can edit' tab, access 'I can view' tab, access 'I created' t' at line 1 query: UPDATE permission SET perm = 'view advanced help index, view advanced help popup, view advanced help topic, access news feeds, administer news feeds, administer blocks, use PHP for block visibility, create blog entries, delete any blog entry, delete own blog entries, edit any blog entry, edit own blog entries, access printer-friendly version, add content to books, administer book outlines, create new books, clone node, clone own nodes, access comments, administer comments, post comments, post comments without approval, Use PHP input for field settings (dangerous - grant with care), view date repeats, administer date_php4 settings, access fckeditor, administer fckeditor, allow fckeditor file uploads, administer filters, create images, edit images, edit own images, view original images, administer image galleries, import images, access advanced options, access all images, access img_assist, use original size, administer lightbox2, download original image, administer menu, access 'All' tab, access 'I can edit' tab, access 'I can view' tab, access 'I created' tab, access 'I last modified' tab, access 'Published' tab, access 'Unpublished' tab, administer mp3player, access content, administer content types, administer nodes, create assignment content, create book content, create event content, create group content, create page content, create story content, create wiki content, delete any assignment content, delete any book content, delete any event content, delete any group content, delete any page content, delete any story content, delete any wiki content, delete own assignment content, delete own book content, delete own event content, delete own group content, delete own page content, delete own story content, delete own wiki content, delete revisions, edit any assignment content, edit any book content, edit any event content, edit any group content, edit any page content, edit any story content, edit any wiki content, edit own assignment content, edit own book content, edit own event content, edit own group content, edit own page content, edit own story content, edit own wiki content, revert revisions, view revisions, export bulk nodes, export node, export own nodes, import nodes, administer organic groups, add own group vocabulary, administer own group vocabulary, edit own group term, edit own group vocabulary, administer url aliases, create url aliases, access print, administer print, node-specific print configuration, publish *all* content, unpublish *all* content, access 'Pending' tab, edit revisions, publish revisions, unpublish current revision, view revisions of own content, administer shoutbox, delete own shouts, edit own shouts, moderate shoutbox, post shouts, post shouts without approval, access administration pages, access site reports, administer actions, administer files, administer site configuration, select different theme, administer taxonomy, upload files, view uploaded files, access user profiles, administer permissions, administer users, change own username, import users, og user import, access all views, administer views, use views exporter, access own webform submissions, access webform results, clear webform results, create webforms, edit own webform submissions, edit own webforms, edit webform submissions, edit webforms, use PHP for additional processing, access workflow summary views, administer workflow, schedule workflow transitions, administer own workspace, administer workspaces, view all workspaces' WHERE rid = 3 in /var/www/html/OURSITE.net/sites/all/modules/image/contrib/image_gallery/image_gallery.install on line 77.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'All' tab, access 'I can edit' tab, access 'I can view' tab, access 'I created' t' at line 1 query: UPDATE permission SET perm = 'view advanced help index, view advanced help popup, view advanced help topic, access news feeds, administer news feeds, administer blocks, use PHP for block visibility, create blog entries, delete any blog entry, delete own blog entries, edit any blog entry, edit own blog entries, access printer-friendly version, add content to books, administer book outlines, create new books, clone node, clone own nodes, access comments, administer comments, post comments, post comments without approval, Use PHP input for field settings (dangerous - grant with care), view date repeats, administer date_php4 settings, access fckeditor, administer fckeditor, allow fckeditor file uploads, administer filters, create images, edit any images, delete any images, edit own images, delete own images, view original images, administer images, import images, access advanced options, access all images, access img_assist, use original size, administer lightbox2, download original image, administer menu, access 'All' tab, access 'I can edit' tab, access 'I can view' tab, access 'I created' tab, access 'I last modified' tab, access 'Published' tab, access 'Unpublished' tab, administer mp3player, access content, administer content types, administer nodes, create assignment content, create book content, create event content, create group content, create page content, create story content, create wiki content, delete any assignment content, delete any book content, delete any event content, delete any group content, delete any page content, delete any story content, delete any wiki content, delete own assignment content, delete own book content, delete own event content, delete own group content, delete own page content, delete own story content, delete own wiki content, delete revisions, edit any assignment content, edit any book content, edit any event content, edit any group content, edit any page content, edit any story content, edit any wiki content, edit own assignment content, edit own book content, edit own event content, edit own group content, edit own page content, edit own story content, edit own wiki content, revert revisions, view revisions, export bulk nodes, export node, export own nodes, import nodes, administer organic groups, add own group vocabulary, administer own group vocabulary, edit own group term, edit own group vocabulary, administer url aliases, create url aliases, access print, administer print, node-specific print configuration, publish *all* content, unpublish *all* content, access 'Pending' tab, edit revisions, publish revisions, unpublish current revision, view revisions of own content, administer shoutbox, delete own shouts, edit own shouts, moderate shoutbox, post shouts, post shouts without approval, access administration pages, access site reports, administer actions, administer files, administer site configuration, select different theme, administer taxonomy, upload files, view uploaded files, access user profiles, administer permissions, administer users, change own username, import users, og user import, access all views, administer views, use views exporter, access own webform submissions, access webform results, clear webform results, create webforms, edit own webform submissions, edit own webforms, edit webform submissions, edit webforms, use PHP for additional processing, access workflow summary views, administer workflow, schedule workflow transitions, administer own workspace, administer workspaces, view all workspaces' WHERE rid = 3 in /var/www/html/OURSITE.net/sites/all/modules/image/image.install on line 357.

The log showed: Failed: UPDATE {permission} for both Image Gallery and Image

Advice?

geoff

Comments

joachim’s picture

Priority: Normal » Critical
Status: Active » Needs review

Ouch!
Turns out we didn't correctly do our db_query() call there.

Can you test this patch please?

joachim’s picture

StatusFileSize
new2.05 KB
David Stosik’s picture

Status: Needs review » Needs work

Sadly, this patch won't work because update_sql() does not support %-substitution parameters...

David Stosik’s picture

Assigned: Unassigned » David Stosik
Status: Needs work » Needs review
StatusFileSize
new2.51 KB

This patch should work.

joachim’s picture

Status: Needs review » Fixed

Committed, thanks!

ggevalt’s picture

Sorry,
Didn't see this until right now. Does this mean that this patch has been incorporated into Beta2?

thanks (and thanks for your hard work.)

geoff

joachim’s picture

Please compare date of release of beta2 and date of my comment above. For definitive answer, see changelog.

ggevalt’s picture

Thanks,
New version seemed to update just fine. No errors.

Let me know if I can be of help in testing or anything else. We are not coders -- we are users/developers who work with schools and kids. We think this is a great module and we really appreciate all of your work on it.

geoff

joachim’s picture

There's a few patches that need testing if that is something you feel able to have a go at.
The main issue queue will let you filter by 'needs review' which means a patch needs people to test it.
There's a list of the main issues we need to get fixed for a release here: http://drupal.org/node/486546
If you use galleries, you may be interested in this: http://drupal.org/node/564488

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.