Nothing happens when the core patch is not yet applied?

murokoma - September 5, 2009 - 03:01
Project:CDN integration
Version:6.x-1.1
Component:Module
Category:support request
Priority:minor
Assigned:Wim Leers
Status:fixed
Description

Hello,

I tried your module as this would be great for some of our homepages.

However, after patching drupal core and installng the module, nothing happens. I activated the the module in settings (Basic mode), on the basic page added my CDN - but the statistics at the bottom of the page as well as firebug/yslow show 0 files.

Furthermore, I get the following error on all pages:

warning: Division by zero in /home/kirobch/public_html/members/sites/all/modules/cdn/theme.inc on line 43.

Any ideas?
Best regards,
Robert

#1

asinnema - October 28, 2009 - 19:34

I have the same issue on a fresh install. Subscribing! :)

#2

Wim Leers - October 28, 2009 - 20:40
Priority:normal» minor
Assigned to:Anonymous» Wim Leers
Status:active» postponed (maintainer needs more info)

I had overlooked this issue apparently.
I have no idea what could be wrong … at the very least, the files should be detected. Because, after all, the code is either patched or it isn't.

asinnema: can you please do some debugging to point me to what could be wrong, because I have nothing to start from here.

Marking as minor because this only appears to be happening in about 1% of the cases.

#3

asinnema - October 28, 2009 - 22:54

The problem is, all I did was upload the module, switch it on, then I went into the debugging settings, selected "debug mode", and when I went to another tab (after saving inbetween) I got the error. I switched it off for now, but that's basically all that happened. Oh, and it was on first day of a clean install.

(on http://www.studieafronden.nl ) :)

I'll be coming back to this thread once a day to see in what way I can help. I'm not a super-Drupaller so don't expect me to understand anything beyond the word "patch" but I'll gladly do what I can.

#4

murokoma - November 1, 2009 - 20:06

Hi there,

Any news on this?

Best regards,
R.

#5

Wim Leers - November 1, 2009 - 21:08

As I already said, I don't have enough information to be able to reproduce it.

Can you reproduce this on a vanilla Drupal site? If you cannot, keep on adding modules that you're using on your actual site until the problem is reproduced.

When you're able to reproduce this (on a vanilla Drupal site with the minimum number of modules to reproduce it), then please make a screencast of:

  1. your site configuration
  2. the problem being reproduced

That makes it easier for me to reproduce the problem. Thanks!

P.S.: don't have any screencast software yet? On Windows and Mac OS X, you can use the free Jing.

#6

scifisi - November 19, 2009 - 17:12

Same here,

Fresh install of Drupal 6.14 (I haven't installed the patch yet), activated the plugin (Debug mode) and ... warning: Division by zero in W:\{path to domain}\sites\all\modules\cdn\theme.inc on line 43.

I heard yesterday that Google will be looking at site optimisation as a criteria for search placement, so as of 2010 having a CDN will soon start to directly influence ranking.

I've got my IIS6 server cacheing and gZipping and with ETags removed, just need to get parallel requests working with CDN - any ideas wazz up?

As this is the same error asinnema and murokoma - could it be because I haven't applied the patch? Could it be that the others haven't applied the patch correctly? Just throwing around some ideas...

This would be a very cool plugin to have working :)

@Wim Leers, if I can help you get to the bottom of this I will, feel free to contact me.

http://www.caspianit.co.uk/iis6-compression-for-php-how-to-compress-css-...

Sci-Fi Si

#7

Wim Leers - November 19, 2009 - 20:45
Category:bug report» support request
Status:postponed (maintainer needs more info)» fixed

Ehm …

Installation
------------
1) Apply the Drupal core patch (patches/drupal6.patch). Instructions can be
   found at http://drupal.org/patch/apply.

That's the *first step*. Obviously it'll fail without the core patch. It's a necessity and without it, you will indeed get errors.

Apply it and you'll be good to go :)

#8

asinnema - November 21, 2009 - 00:37

Pah, reading readme files is for wussies and smart people! ;)

Talking about smart people.. um.. what would be the whole url for that drupal6 patch file? :s

#9

Wim Leers - November 21, 2009 - 09:17

README's are there to respect the developer's time, he can't answer the same questions over and over again ;)

The patch is included in the module. No need for a URL. Apply the patch like any other core patch.

#10

asinnema - November 21, 2009 - 12:39

Okay. Then I'll be ok :) Will check back if there's anything else.

As far as the readme goes, it was a joke, of course the joke's on me! :)

#11

Wim Leers - November 21, 2009 - 13:55

I couldn't know if you were joking or not. It's true that *very* few people read the README, so :P

#12

asinnema - November 22, 2009 - 19:55

I've worked in tech support, people wouldn't admit to not reading the readme, they'd just go "I'm an expert", and "brb while I check something else that's in fact the thing you just suggested but I don't want to lose face" ;)

Edited to add: also a lot of people on the phone claiming to have worked in tech support that wouldn't read the darn manual.. hmm, I guess I just became one of those ;)

Haven't tried this again yet, so nothing new to report so far. Will be back.

#13

Wim Leers - November 22, 2009 - 19:39
Title:Nothing happens?» Nothing happens when the core patch is not yet applied?

Hehe :)

Ok, let me know how it goes.

 
 

Drupal is a registered trademark of Dries Buytaert.