Patch is the result of:

perl -pie 's/_peddle/pedal/g' taxonomy.admin.inc

CommentFileSizeAuthor
#8 569024-2.drupal.taxonomy-back-pedal-spelling.patch7.24 KBjoachim
#4 569024.drupal.taxonomy-back-pedal-spelling.patch7.25 KBjoachim
taxonomy-backpedal.patch5.4 KBjoachim

Comments

attiks’s picture

attiks commented

Patch looks good
+1

Status: Needs review » Needs work

The last submitted patch failed testing.

nvanhove’s picture

nvanhove commented

If it is renamed in PHP, it should also be renamed in the Javascript to be consistent.

drupal_add_js(array('taxonomy' => array('backPeddle' => $backpedal, 'forwardPeddle' => $forwardpedal)), 'setting');
joachim’s picture

joachim commented
Status: Needs work » Needs review
StatusFileSize
new 569024.drupal.taxonomy-back-pedal-spelling.patch7.25 KB

Well spotted :)

perl -pi -e 's/(_peddle|Peddle)/pedal/g' modules/taxonomy/taxonomy.*
nvanhove’s picture

nvanhove commented

Patched installed and I can still drag&drop the terms on the following page:
admin/structure/taxonomy/1

Also a

grep -Ri "Peddle" *

is now empty, so it is fine by me :)

nvanhove’s picture

nvanhove commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

You know, as cute as "backpedal" is as a name of this variable, since "forwardpedal" is not a word, and I forsee another person coming along in a few weeks to fix that, I wonder if there is some other pair we could name these instead.

$back_step, $forward_step, maybe?

joachim’s picture

joachim commented
Status: Needs work » Needs review
StatusFileSize
new 569024-2.drupal.taxonomy-back-pedal-spelling.patch7.24 KB

FWIW I don't think neologisms that have some kind of foundation to them (prepend, forwardpedal) are half bad as what we had, but here's a new patch with webchick's suggested names.

perl -pi -e 's/_peddle/_step/g' modules/taxonomy/taxonomy.*
perl -pi -e 's/Peddle/Step/g' modules/taxonomy/taxonomy.*

mrfelton’s picture

mrfelton commented
Status: Needs review » Reviewed & tested by the community

Patch applied and tested:
Creating vocabs, creating terms, drag/drop of vocabs and terms.

Works for me.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.