Improve redirect mechanism for merged terms
mh86 - September 5, 2009 - 10:25
| Project: | Taxonomy Manager |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
As discussed in #567564: Disable the taxonomy/term display by default we shouldn't use the menu_alter to redirect merged terms, because this breaks other modules like Taxonomy Breadcrumb and Panels3.
By default, the redirect is now disabled and it's working with other modules, but there might be better ways to implement this.
So I started an issue where we can work on a patch
#1
Subscribing. I suggest using Path_Redirect if available.
#2
Initial patch that..
#3
#4
That patch has an error in it. You need to change module_enabled('path_redirect') to module_exists('path_redirect')
With that change, the patch appears to do the right thing and is a welcome improvement.
Given that I also confirmed the incompatibility with Panels 3, I would suggest removing the existing redirect functionality entirely, and have the module just do a path_redirect by default instead (but still allow the checkbox to be unchecked). That would make path_redirect a prerequisite for this module, which would be fine.
#5
Gah. I forgot to update the module with my local test code. Here's a corrected patch.
#6
Thanks for the patch Damien. Maybe it would be useful to add a default option or omit the whole options thing. After all, it is the expected behaviour, when using the redirect module:
if (count($options) > 0) {$form['merge']['options'] = array(
'#type' => 'checkboxes',
'#title' => t('Options'),
'#options' => $options,
);
+ if (module_exists('path_redirect')) {
+ $form['merge']['options']['#default_value'] = array('merge_redirect');
+ }