Primary tab links loose paddding when in active trail
Manuel Garcia - September 5, 2009 - 10:46
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | Seven theme |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Description
Situation:
You are in a secondary tab menu item, like for example /admin/structure/node-type/article/display/search , and the active primary tab, which in this case would be "Display fields", looses the padding on the a element. This is due to the a loosing the class "active".
See attached screenshot to see the problem.
Proposed fix:
Just with css, we could use the li.active a so that the a stil gets the padding even if the a itself isn't getting the active class.
I attach a patch that gets this change in, not very experienced creating patches using diff, so I hope it came out ok =)
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| style.patch | 424 bytes | Idle | Failed: Failed to install HEAD. | View details | Re-test |
| seven.png | 7.26 KB | Ignored | None | None |
#1
The last submitted patch failed testing.
#2
Hummm patch is applying fine from my drupal root install... :X
#3
It looks like this has been fixed already - see screenshot. Marking as duplicate.
#4
I'm not sure it's the same issue, but i grabbed head this morning, and while browsing around testing out the fields for users, I came upon this again, see the attached screenshot.
It seems that reset.css line 10 is affecting the padding of these active tabs, see on screenshot 2 that i disable that padding reset and the tab displays correctly.
I have applied the patch and the problem goes away, though not sure what changes have been made since i wrote this small patch.
#5
The above no longer is happening, however I see the issue now if you are in one of the menu items from the secondary tabs, but not the first one.
So it happens in /admin/appearance/settings/garland, but not in /admin/appearance/settings/
See attached screenshot, in ff 3.0.15 on ubuntu.
I don't know why this is happening only in the second/third/etc links in the secondary tabs, and not in the first one. The markup is the same afik. Either way, the patch solves the problem.
#6
The last submitted patch failed testing.