Situation:

You are in a secondary tab menu item, like for example /admin/structure/node-type/article/display/search , and the active primary tab, which in this case would be "Display fields", looses the padding on the a element. This is due to the a loosing the class "active".

See attached screenshot to see the problem.

Proposed fix:

Just with css, we could use the li.active a so that the a stil gets the padding even if the a itself isn't getting the active class.

I attach a patch that gets this change in, not very experienced creating patches using diff, so I hope it came out ok =)

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

manuel garcia’s picture

Status: Needs work » Needs review

Hummm patch is applying fine from my drupal root install... :X

arianek’s picture

Status: Needs review » Closed (duplicate)
StatusFileSize
new21.29 KB

It looks like this has been fixed already - see screenshot. Marking as duplicate.

manuel garcia’s picture

StatusFileSize
new131.39 KB
new131.23 KB

I'm not sure it's the same issue, but i grabbed head this morning, and while browsing around testing out the fields for users, I came upon this again, see the attached screenshot.

It seems that reset.css line 10 is affecting the padding of these active tabs, see on screenshot 2 that i disable that padding reset and the tab displays correctly.

I have applied the patch and the problem goes away, though not sure what changes have been made since i wrote this small patch.

manuel garcia’s picture

Status: Closed (duplicate) » Needs review
StatusFileSize
new7.79 KB
new518 bytes

The above no longer is happening, however I see the issue now if you are in one of the menu items from the secondary tabs, but not the first one.

So it happens in /admin/appearance/settings/garland, but not in /admin/appearance/settings/

See attached screenshot, in ff 3.0.15 on ubuntu.

I don't know why this is happening only in the second/third/etc links in the secondary tabs, and not in the first one. The markup is the same afik. Either way, the patch solves the problem.

Status: Needs review » Needs work

The last submitted patch failed testing.

Jeff Burnz’s picture

I assume this is no longer and issue and was fixed in some other issue?

aspilicious’s picture

Status: Needs work » Fixed

Yeah this is fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.