Extra stuff in "International" breaks layout

NancyDru - September 5, 2009 - 12:53
Project:Phone (CCK)
Version:6.x-2.10
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

The extra long label for "International" (the link to the spec) causes the select field to be way too long for the screen, causing the set up of the field to extend off the right side of the page. Please remove the link.

#1

Ogredude - September 10, 2009 - 04:39

I agree.
Or maybe have an options setup so you can choose which type(s) of phone numbers you want to use on your site. Some of us only need US phone numbers.

#2

jshuster@drupal.org - September 22, 2009 - 19:10
Status:active» needs review

Here's a patch that shortens the overly-long label.

AttachmentSize
phone.module.569188.patch 601 bytes

#3

NancyDru - September 23, 2009 - 01:41

On my site, I just shortened it to "International Phone Numbers".

+1 for RTBC

#4

samchok - September 23, 2009 - 09:50

Shorter labels are needed.
It could be also useful to name them "Phone (UK)", "Phone (IT)" and so on... so that the Phone fields are all ordered sequentially. Even if Ogredude (#1) suggestion could be a better choice.

#5

servantleader - September 26, 2009 - 03:12

+1

#6

nwwoman - October 9, 2009 - 21:19

Agree with #1

#7

nwwoman - October 9, 2009 - 21:33

I'm not a coder and have never done a patch but do need this. Before I do the following, I need a coder to tell me if what I read is true: "Patch by hand. The +++ get added and the --- get removed."

I'm on a winxp dev machine/standalone. If that's all I need to do, then I'm good to go. Will wait for someone to let me know if it's OK to proceed. Don't want to break anything! Thanks!!

#8

NancyDru - October 9, 2009 - 23:48
Status:needs review» reviewed & tested by the community

Yes, that's the way it works. Actually just go to that line and reduce the text. It's very simple. Just make sure the beginning and ending quotes are still there and you don't run much risk.

#9

nwwoman - October 9, 2009 - 23:49

Thanks Nancy! It's working great!

#10

thierry_gd - October 27, 2009 - 21:51
Status:reviewed & tested by the community» fixed

Fixed in 6.2.10 release

#11

thekevinday - October 30, 2009 - 14:04
Version:6.x-2.9» 6.x-2.10
Status:fixed» active

Sorry, but it seems you missed removing the trailing </a> in your 6.x-2.10 release.

#12

nwwoman - November 1, 2009 - 22:03

Revised the international line per the patch but new question that came up: Can we remove some of these foreign phone #s from the select field without breaking the module?

#13

thierry_gd - November 5, 2009 - 14:11
Status:active» fixed

Fix in 6.2.11 release

#14

System Message - November 19, 2009 - 14:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.