The extra long label for "International" (the link to the spec) causes the select field to be way too long for the screen, causing the set up of the field to extend off the right side of the page. Please remove the link.

CommentFileSizeAuthor
#2 phone.module.569188.patch601 bytesjshuster@drupal.org

Comments

Ogredude’s picture

Ogredude commented

I agree.
Or maybe have an options setup so you can choose which type(s) of phone numbers you want to use on your site. Some of us only need US phone numbers.

jshuster@drupal.org’s picture

jshuster@drupal.org commented
Status: Active » Needs review
StatusFileSize
new phone.module.569188.patch601 bytes

Here's a patch that shortens the overly-long label.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

On my site, I just shortened it to "International Phone Numbers".

+1 for RTBC

samchok’s picture

samchok commented

Shorter labels are needed.
It could be also useful to name them "Phone (UK)", "Phone (IT)" and so on... so that the Phone fields are all ordered sequentially. Even if Ogredude (#1) suggestion could be a better choice.

servantleader’s picture

servantleader commented

+1

Sunshiney’s picture

Sunshiney commented

Agree with #1

Sunshiney’s picture

Sunshiney commented

I'm not a coder and have never done a patch but do need this. Before I do the following, I need a coder to tell me if what I read is true: "Patch by hand. The +++ get added and the --- get removed."

I'm on a winxp dev machine/standalone. If that's all I need to do, then I'm good to go. Will wait for someone to let me know if it's OK to proceed. Don't want to break anything! Thanks!!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Needs review » Reviewed & tested by the community

Yes, that's the way it works. Actually just go to that line and reduce the text. It's very simple. Just make sure the beginning and ending quotes are still there and you don't run much risk.

Sunshiney’s picture

Sunshiney commented

Thanks Nancy! It's working great!

thierry_gd’s picture

thierry_gd commented
Status: Reviewed & tested by the community » Fixed

Fixed in 6.2.10 release

thekevinday’s picture

thekevinday commented
Version: 6.x-2.9 » 6.x-2.10
Status: Fixed » Active

Sorry, but it seems you missed removing the trailing </a> in your 6.x-2.10 release.

Sunshiney’s picture

Sunshiney commented

Revised the international line per the patch but new question that came up: Can we remove some of these foreign phone #s from the select field without breaking the module?

thierry_gd’s picture

thierry_gd commented
Status: Active » Fixed

Fix in 6.2.11 release

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.