This is a nice, simple module, and it does almost exactly what I need. However, I wish I had the ability to remove the input formats text. I use the Better Formats module, but since this doesn't seem to be a "node type," I can't configure it to remove all of the formatting text like I can throughout the rest of the site.

Also, I wish there was a permission regarding visibility. As it stands, you cannot remove the options. However, in my case, I only want Annotations to be private - I never care that anyone else sees them. But I can't remove the option to make them public.

Finally, it would be nice if you could change the text that provides instructions, below the input box.

CommentFileSizeAuthor
#5 annotate_570008_5.patch1.79 KBmhunt
#4 annotate_570008_4.patch447 bytesthesleuth
#3 annotate_570008_3.patch3 KBscottrigby
#3 Picture 3.png79.45 KBscottrigby

Comments

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

1. Better Formats
Can we integrate with Better Formats? Do you mind to check for that :)

2. Configurable visibility
Nice idea ... have to think about it after I've fixed the 6.x-1.x-dev version

3. Better instructions
Please provide the text ;)

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Active » Postponed (maintainer needs more info)
scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new Picture 3.png79.45 KB
new annotate_570008_3.patch3 KB

@clemens.tolboom: Hi

  1. Better formats -- seems to work on the input format selection options and the fieldset itself, but doesn't properly hide the tips or tip link (see screenshot). A quick glance at through annotate_private_entry_form() didn't give me any immediate answers as to why... but something to look into.
  2. Configure visibility -- here's a patch that thesleuth & I whipped up. What do you think?
  3. Better instructions -- it aint much, but we also added appropriately descriptive help text on the two new visibility settings form elements.
thesleuth’s picture

thesleuth commented
StatusFileSize
new annotate_570008_4.patch447 bytes

This patch allows for theme override in the note display, by resolving the call of theme function "annotate_node_item"...

mhunt’s picture

mhunt commented
StatusFileSize
new annotate_570008_5.patch1.79 KB

Adding to the patches made by thesleuth and scottrigby. This patch creates div's (prefix and suffix) around the fieldsets for better styling flexibility.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs review » Needs work

Hope to find some time to review test and apply this month.

Please apply the patch to 6.x-1.x-dev then change the version accordingly.

Thanks for helping.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Version: 6.x-1.0 » 6.x-1.x-dev
Assigned: Unassigned » clemens.tolboom
Status: Needs work » Fixed

Hmmm ... patches are a little mixed up :(

But I finally applied #3 #4 and #5 on 6.x-1.x-dev

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Version: 6.x-1.x-dev » 6.x-1.1
Status: Fixed » Closed (fixed)