Download & Extend
Annotate » Issues

Just a bit more UI flexibility

Posted by rayray on September 6, 2009 at 6:32pm
Project:Annotate
Version:6.x-1.1
Component:User interface
Category:feature request
Priority:normal
Assigned:clemens.tolboom
Status:closed (fixed)

Issue Summary

This is a nice, simple module, and it does almost exactly what I need. However, I wish I had the ability to remove the input formats text. I use the Better Formats module, but since this doesn't seem to be a "node type," I can't configure it to remove all of the formatting text like I can throughout the rest of the site.

Also, I wish there was a permission regarding visibility. As it stands, you cannot remove the options. However, in my case, I only want Annotations to be private - I never care that anyone else sees them. But I can't remove the option to make them public.

Finally, it would be nice if you could change the text that provides instructions, below the input box.

Login or register to post comments

Comments

#1

Posted by clemens.tolboom on September 7, 2009 at 12:20pm

1. Better Formats
Can we integrate with Better Formats? Do you mind to check for that :)

2. Configurable visibility
Nice idea ... have to think about it after I've fixed the 6.x-1.x-dev version

3. Better instructions
Please provide the text ;)

#2

Posted by clemens.tolboom on September 18, 2009 at 5:18pm
Status:active» postponed (maintainer needs more info)

#3

Posted by scottrigby on November 10, 2009 at 9:56pm
Status:postponed (maintainer needs more info)» needs review

@clemens.tolboom: Hi

  1. Better formats -- seems to work on the input format selection options and the fieldset itself, but doesn't properly hide the tips or tip link (see screenshot). A quick glance at through annotate_private_entry_form() didn't give me any immediate answers as to why... but something to look into.
  2. Configure visibility -- here's a patch that thesleuth & I whipped up. What do you think?
  3. Better instructions -- it aint much, but we also added appropriately descriptive help text on the two new visibility settings form elements.
AttachmentSize
annotate_570008_3.patch 3 KB
Picture 3.png 79.45 KB

#4

Posted by thesleuth on November 11, 2009 at 5:33pm

This patch allows for theme override in the note display, by resolving the call of theme function "annotate_node_item"...

AttachmentSize
annotate_570008_4.patch 447 bytes

#5

Posted by mhunt on November 19, 2009 at 5:32pm

Adding to the patches made by thesleuth and scottrigby. This patch creates div's (prefix and suffix) around the fieldsets for better styling flexibility.

AttachmentSize
annotate_570008_5.patch 1.79 KB

#6

Posted by clemens.tolboom on November 27, 2009 at 3:33pm
Status:needs review» needs work

Hope to find some time to review test and apply this month.

Please apply the patch to 6.x-1.x-dev then change the version accordingly.

Thanks for helping.

#7

Posted by clemens.tolboom on December 30, 2009 at 4:36pm
Version:6.x-1.0» 6.x-1.x-dev
Assigned to:Anonymous» clemens.tolboom
Status:needs work» fixed

Hmmm ... patches are a little mixed up :(

But I finally applied #3 #4 and #5 on 6.x-1.x-dev

#8

Posted by clemens.tolboom on January 2, 2010 at 12:44pm
Version:6.x-1.x-dev» 6.x-1.1
Status:fixed» closed (fixed)
nobody click here