Hi there,

I'm using UR to add a Twitter-like one-way "follow" relationship to a site. Since it's one way, this relationship doesn't require approval.

However I've noticed that when you activate a relationship that doesn't require approval, no e-mail notification is sent to the person on the other end. Maybe this is a bug?

If it's intentional, how can I hack the code to get notifications to appear when approval-less relationships are created? The whole point of a module like UR is to let people interact with eachother. If my relationships aren't generating notification e-mails, then no one will know someone's trying to interact with them on the site.

Thanks!

Comments

bflora’s picture

bflora commented

I made an edit to user_relationships_mailer.module that seems to have solved the problem. Alex, let me know if what I did was really bad.

I chanced line 21 from

 if (($op == 'request' && $relationship->approved) || !variable_get("user_relationship_mailer_send_{$op}", TRUE)) { 
    return; 
  }

to 

 if (($op == 'request' && !$relationship->approved) || !variable_get("user_relationship_mailer_send_{$op}", TRUE)) { 
    return; 
  }

Notice the "!" I added to the first condition? This seems to be letting me generate e-mail notifications for relationships that don't require approval.

alex.k’s picture

alex.k commented

That should work for you, but it just reverses the action to only email on approved relationships. You could just remove the check altogether to have it email in all cases. UR 6.x has a different 'pre-approved' action and mail template, so that it's more useful to sites that do use both types of relationships.

bflora’s picture

bflora commented

What would removing it altogether look like?

Like this?

if (!variable_get("user_relationship_mailer_send_{$op}", TRUE)) {
    return;
  }
alex.k’s picture

alex.k commented

Yup, correct :)

alex.k’s picture

alex.k commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.