Hi,

first of all: very nice and useful module.

I just ran into an issue, where users without the "administer menu" permission didn't have access to the "Menu settings" fieldset on node creation pages. The reason for this behaviour was in the function menu_admin_per_menu_form_alter().

It is possible to see the error, with the following scenario:
Menus (each one with a number of childs):
menu_1
menu_2
menu_3

If the current user has the permision to modify menu_3, but the default menu is menu_1 or menu_2 then the "Menu settings" fieldset will not be visible.

I want to propose the attached patch in order to fix this problem. I have applied the patch successfully on the latest Download of this module and I did not find any problems.

best regards,
Hadubard

CommentFileSizeAuthor
menu_admin_per_menu.patch560 bytesberliner

Comments

anrikun’s picture

anrikun commented

Hi,
What do you mean by "the default menu is menu_1 or menu_2"?

anrikun’s picture

anrikun commented
Category: bug » feature
Status: Needs review » Needs work

Thank you for your contribution.
After rethinking for a while, I think that I understand what you mean.
You mean that when a user has the permission to modify menu_3 but not menu_1, and tries to edit a node currently attached to a menu item from menu_1, he cannot see the "Menu settings" fieldset, right?
Then this is by design: as user has not the permission to modify menu_1, he cannot admin menu_1 items and thus cannot change "Menu settings" of nodes attached to menu_1 items.

anrikun’s picture

anrikun commented
Category: feature » bug
Status: Needs work » Closed (works as designed)
berliner’s picture

berliner commented

Hi,

ok, now I understand your concept. I was just restructuring my menus and you are right in that the node in question still belonged to a menu that the current user didn't have the permission to edit.

Sorry that I bothered you with that and thanks for your explication.

beste regards,
berliner