Editing term name does not work

maverick14 - September 8, 2009 - 07:15
Project:Taxonomy Manager
Version:6.x-2.1
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:needs review
Description

Hello there,

I think I found a bug in the Taxonomy Manager, when I edit a term and then try to change the name. Steps I did:

- click on the term in the overview list
- then edit the name field
- then hit the button "save changes"
- systems says: "Changes successfully saved"
- the overview shows the renamed term

But when I refresh the page, I still see my old term name ... So nothing has changed ...

Anyone with the same issue?

AttachmentSize
example.jpg100.74 KB

#1

mh86 - September 9, 2009 - 08:06

Hi!

I tried to reproduce this issue by following your steps, but had no problems with renaming (you can try that on my demo site, e.g. at http://mhutterer.at/?q=admin/content/taxonomy_manager/voc/24).
Further I can't open your image.

#2

maverick14 - September 9, 2009 - 14:22

Hello Matthias,

Thanks for your quick response. I tried it on you website and indeed: it works! I'm using the same version as you do (2.1) and still there are differences in my installation. I tried with de-activating other modules that work with taxonomy, but still the term name is not changeable. Very weard.

I'll try out a new drupal 6 installation and with only your module, and let you know!

#3

maverick14 - September 10, 2009 - 07:22
Status:active» fixed

Yep. In a clean Drupal installation it's working ... But in my implementations something goes wrong. Thanks for your time. Sorry for bothering!

#4

serkan.arikusu - September 10, 2009 - 13:56

I have the same problem.
When I edit a term, it is shown as updated, but when I reload the page I can see that nothing changed.
The problem may be with xmlsitemap module, here is something from the log

/sites/all/modules/xmlsitemap/xmlsitemap.module file 805. line Duplicate entry '0-taxonomy' for key 1 query: INSERT INTO xmlsitemap (type, loc, access, status, lastmod, priority, priority_override, changefreq, changecount, term_vid) VALUES ('taxonomy', 'taxonomy/term/', 1, 0, 0, NULL, NULL, 0, 0, NULL).

#5

serkan.arikusu - September 10, 2009 - 14:05
Status:fixed» active

Hi again,
I disabled xmlsitemap but now I get the following error for taxonomy term artvin sel, which I tried to make the first letter upper case as Artvin sel

/modules/path/path.module file 112. line Duplicate entry 'haberleri/artvin-sel/feed-' for key 2 query: INSERT INTO url_alias (src, dst, language) VALUES ('taxonomy/term/488/feed', 'haberleri/artvin-sel/feed', '').

#6

mh86 - September 10, 2009 - 14:42

thanks for reporting back. seems like there is a problem when taxonomy manager is invoking the hook_taxonomy. I have to take a look at this

#7

KNOFF - October 9, 2009 - 10:20
Priority:critical» normal
Assigned to:Anonymous» KNOFF
Status:active» needs review

Hello.
I think, I can help little-bit.
I checked requests to the server and found some thing, that make mistakes in many other AJAX based modules.
I spoke about operation name: op=Save changes. This string getting from the button title. In the localized interfaces this string can be different and operation doesn't processed on server. In Russian interface this string looks as op=Соханить изменения.
When I deleted translation string from DB, module works perfect.

#8

KNOFF - October 9, 2009 - 10:40
Priority:normal» critical
Assigned to:KNOFF» Anonymous

Oooups. Priority and assigned flags changed by my post...

#9

lemark - October 11, 2009 - 08:28
Status:needs review» active

I have the same problem. I have deleted the translation string, but without any visible results.

#10

sudoku - October 14, 2009 - 01:53

Hi,
having the same problems - same thing with adding a description to the term (always telling: Changes successfully saved). Merging terms seem to work.

#11

gabor_h - October 22, 2009 - 19:17
Status:active» needs review

The solution:
In the function taxonomy_manager_term_data_edit() change the following line
if ($op == "Save changes") {
to
if ($op == t("Save changes")) {

mh86, please make this change in the next version.

#12

ISchier770 - November 2, 2009 - 18:24

BS"D

Tried the above and got a white screen of death. Was I supposed to make the change in the taxonomy_manager.admin.inc file or elsewhere?

Meanwhile, neither my descriptions nor my edits save and I have to handle that from the taxonomy admin function itself.

Thanks, Itzhak

#13

deepM - November 2, 2009 - 22:35

I am having exact same problem, also had it with older version of Tax. Manager, i tought it was something with wrong with my installation etc. But it seems its a locale problem as it happened when i installed other languages.

Seems this helps

if ($op == t("Save changes")) {

thanx gabor_h

#14

ISchier770 - November 3, 2009 - 09:29

BS"D

Tried that again - white screen again!

Here is the white screen log entry:

php
Date Tuesday, November 3, 2009 - 11:21
User Itzhak770
Location http://billioneers.com/admin/content/taxonomy_manager/voc/1
Referrer http://www.billioneers.com/admin/content/taxonomy_manager/voc/1
Message Cannot modify header information - headers already sent by (output started at /home/billione/public_html/sites/all/modules/taxonomy_manager/taxonomy_manager.admin.inc:1) in /home/billione/public_html/includes/common.inc on line 335.

Can anyone help? This module is great even for just entering more than one term at a time but it would help a lot if I could use it to edit and enter my descriptions! Thanks, Itzik

#15

gabor_h - November 5, 2009 - 13:48

Hi,

In my experience this error at taxonomy_manager.admin.inc:1 means that you edited the file with an editor that puts the so called BOM in the beginning of the UTF-8 file.

Info about the BOM:
http://en.wikipedia.org/wiki/Byte-order_mark

Here is one editor that can edit various files in various formats (also with and without BOM):
http://notepad-plus.sourceforge.net
I am sure there are many others.

In other words, the line modification I mentioned earlier is correct, the white screen you get is only because of your editor.

 
 

Drupal is a registered trademark of Dries Buytaert.