it would be just unbeatable to have token integration for "Link title" and "Link hover title" textfields
having the ability to use referenced node's title, nid, etc (the nid would be nice for tracker whether issues are followed with links like [#123])
then it would be possible to add titles like Add a new issue to project: [title] or Add a new whatever to issue #[nid]

CommentFileSizeAuthor
#10 token_support.patch1.76 KBigor.ro
#1 2009-09-13_token_support.patch4.63 KBarhak
#1 2009-09-13_token_support.patch4.63 KBarhak

Comments

arhak’s picture

arhak commented
Title: token support for "Link title" and "Link hover title" » token support for "Link title" and "Link hover title" (patch provided)
Status: Active » Needs review
StatusFileSize
new 2009-09-13_token_support.patch4.63 KB
new 2009-09-13_token_support.patch4.63 KB

I'm not a token savvy, thus, this is a working patch to be reviewed, but most likely it will need some clean up

arhak’s picture

arhak commented

this patch must consider stop using the 'token' namespace (declaring function theme_token_list) in case this other patch gets committed to token module: #576592: theme_token_list (split theme_token_help in two)

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Needs work
arhak’s picture

arhak commented
Title: token support for "Link title" and "Link hover title" (patch provided) » token support for "Link title" and "Link hover title"

well, yeah.. it has TODO marks
but:
- does it work in a desirable manner?
- what would be the areas it needs work?

quicksketch’s picture

quicksketch
he/him
commented

Basically it needs the TODOs cleaned up. We shouldn't be using the token module namespace, I doubt that major API change will happen in the Drupal 6 version of the module, so we'd best just make our own theme function. We did the same thing for Flag module, see http://api.lullabot.com/theme_flag_token_help

arhak’s picture

arhak commented
Assigned: Unassigned » arhak

thanks for the clarification

arhak’s picture

arhak commented
Assigned: arhak » Unassigned

actually, I'm gonna be very busy this month
anyone can pick this up, it's pretty much done (I think)

mattiasj’s picture

mattiasj commented

This would be a great addition, and clearly bring a greater experience to editors. Any progress on this patch?

arhak’s picture

arhak commented

just clean up the code considering what quicksketch pointed at #5

igor.ro’s picture

igor.ro commented
StatusFileSize
new token_support.patch1.76 KB

We do not need adding new token type.

Here is better solution