Patch to allow input of Google videos from video.google.com, similar to YouTube videos.

The videos need everything from the embed code they give you after 'videoUrl='. So for example this link: http://video.google.com/videoplay?docid=-1591729516923874694 has this embed code:

<embed style="width:400px; height:326px;" id="VideoPlayback" align="middle" type="application/x-shockwave-flash" src="http://video.google.com/googleplayer.swf?videoUrl=http%3A%2F%2Fvp.video.google.com%2F[snipped out ~650 chars]7F2do58g7zo&playerId=-1591729516923874694" allowScriptAccess="sameDomain" quality="best" bgcolor="#ffffff" scale="noScale" wmode="window" salign="TL" FlashVars="playerMode=embedded"> </embed>

So you would enter:

http%3A%2F%2F[snipped out ~650 chars]7F2do58g7zo&playerId=-1591729516923874694

I had to increase the field length to 700 chars for google video URLs. They're really long.

I didn't do anything with the help messages or code comments, and some of it could probably be cleaner.

CommentFileSizeAuthor
video.module.google.patch6.67 KBbenthere

Comments

benthere’s picture

benthere commented
Status: Active » Needs review
benthere’s picture

benthere commented

Also, I don't know if it needs those other parameters, but I forgot to add them in the patch.

fax8’s picture

fax8 commented

patch looks good to me.

Please add informations on how to use the google video support
on video_help() and on FILE_TYPES.txt.

Then I will commit this.

Fabio

fax8’s picture

fax8 commented
Status: Needs review » Fixed

committed to cvs. Thanks.

I modified a bit the code contained in your patch.
This was due to a modification of the embed code google did.

Fabio

benthere’s picture

benthere commented

Excellent Fabio. I was just realizing that they changed the embed code and thinking about updating it. You beat me to it. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)