Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Use theme_username() to allow theme overrides and modules like RealName to influence username defaults in submission form.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | print_mail_username.patch | 663 bytes | aether |
| #2 | print_mail_username.patch | 662 bytes | aether |
| print_mail_username.patch | 700 bytes | aether |
Comments
Comment #1
jcnventuraWhy are you calling the theme function twice?
Comment #2
aether commentedNow only called one time.
Comment #3
jcnventuraThe default implementation of theme_username() doesn't accept the plain argument and it returns the HTML pointing to the user page. Since the instances where this string is used require simple text, this patch is unacceptable.
Comment #4
aether commentedAh, right you are. My implementation was specifically related to the RealName module which provides this argument via override. Would strip_tags offer an acceptable workaround as it is used in this patch or is it bad practice to wrap a theme function like this?
Not sure if the check_plain is needed here and will remove it if it is unnecessary in your opinion and the patch is otherwise acceptable.
Comment #5
jcnventuraCommited to CVS. Thanks for the patch!