I noticed this as I was working on #152431: collapsible fieldset problems with #prefix, #suffix, markup rendering, collapse.js has a bunch of coding style problems, mostly just comments without a period at t he end, but also a } else { block on a single line which needed to be spaced out. This patch fixes all the coding style problems I spotted.

CommentFileSizeAuthor
#4 572872-03.patch2.12 KBcwgordon7
#2 572872-02.patch2.02 KBcwgordon7
#1 572872-01.patch1.77 KBcwgordon7

Comments

cwgordon7’s picture

cwgordon7 commented
Issue tags: +Quick fix
StatusFileSize
new 572872-01.patch1.77 KB

Sorry, forgot the patch.

cwgordon7’s picture

cwgordon7 commented
StatusFileSize
new 572872-02.patch2.02 KB

Missed one, sorry!

c960657’s picture

c960657 commented

You may also want to reformat the "// Turn the legend ..." comment so that it wraps at max. 80 characters.

cwgordon7’s picture

cwgordon7 commented
StatusFileSize
new 572872-03.patch2.12 KB

Done, thanks.

c960657’s picture

c960657 commented
Status: Needs review » Reviewed & tested by the community

Looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.