Empty Distance field when using Views filter [#573356]

SELECT node.nid AS nid,
   node.title AS node_title,
   node_data_field_phone.field_phone_value AS node_data_field_phone_field_phone_value,
   node_data_field_phone.nid AS node_data_field_phone_nid,
   node.type AS node_type,
   location.lid AS location_lid,
   'Unknown' AS location_distance_3
 FROM node node 
 LEFT JOIN content_type_location node_data_field_phone ON node.vid = node_data_field_phone.vid
 LEFT JOIN location_instance location_instance ON node.vid = location_instance.vid
 LEFT JOIN location location ON location_instance.lid = location.lid
 WHERE (node.status <> 0) AND (node.type in ('location')) AND (0)
   ORDER BY location_distance_3 ASC

This is if the proximity field has been filled out. Notice the "AND (0)" at the end, so it returns nothing. If I empty the proximity field, that clause disappears, and every field is shown, with nothing in the Distance table fields.

Notice also that there is nothing pertaining to the zip code at all. So this views integration is completely broken.

Can someone address this?

Log in or register to post comments

Comment #5

BartVB commented 4 October 2009 at 12:06

Priority:

Critical

» Normal

Same problem(s) here. The missing data in the 'distance' column seems to be caused in location_handler_field_location_distance.inc()

which contains:

    if ($this->options['origin'] == 'tied') {
      if (!empty($this->view->filter)) {
        foreach ($this->view->filter as $k => $v) {
          if ($v->table == 'location' && $v->field == 'distance' && $v->options['relationship'] == $this->options['relationship']) {
            if ($v->calculate_coords()) {
              $latitude = (float)$v->value['latitude'];
              $longitude = (float)$v->value['longitude'];
            }
          }
        }
      }

Which doesn't seem to pick up the lat/lon of the entered location in the filter.

The 'distance' field is filled properly if you choose 'static location' in the options for this field. Now the question is where the query function is supposed to get the lat/lon from.

Log in or register to post comments

Comment #6

BartVB commented 4 October 2009 at 12:33

Title:	Nothing showing up in Distance field	» Empty Distance field when using Views filter
Version:	6.x-3.1-rc1	» 6.x-3.x-dev
Category:	support	» task
Status:	Active	» Needs review

Status	File	Size
new	location_distance_field_tied.patch	1.05 KB

Ok, looks like I fixed this issue (with my extremely minimal knowledge of the Views framework :D).

It only changes:

          if ($v->table == 'location' && $v->field == 'distance' && $v->options['relationship'] == $this->options['relationship']) {

into

          if ($v->table == 'location' && $v->field == 'distance' && ($v->options['relationship'] == 'none' || $v->options['relationship'] == $this->options['relationship'])) {

to handle the case where a view doesn't have any relationships. Not sure if this is the way to go but works for me :)