Closed (fixed)
Project:
Language Icons
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Sep 2009 at 05:21 UTC
Updated:
8 Sep 2010 at 01:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
Freso commentedPlease provide the changes as a patch.
Comment #2
eMPee584 commentedpatch -p1 < languageicons-d7-port.patchComment #3
Freso commentedAwesome work, thank you. :)
I found two issues though:
Comment #4
Freso commentedWhile being mostly just style corrections (mostly guided by Coder), I have committed the attached patch for some initial 7.x compatibility. It's far from there yet, but it's a step towards it.
Comment #5
Freso commentedComment #6
Freso commentedAnd I just got the theming in place, so that should work now as well.
Comment #7
Freso commentedAnd this was apparently what was needed to actually make Language icons display some icons. Since it does that now, this issue is fixed. There are still some bugs though; like the fact that the code doesn't currently take the difference between the links in the block and at the node into account - but separate issues will have to be created for this and others.
Comment #9
klonosJust started doing some testing with the latest Drupal 7.x-dev builds and I see no icons no matter what option is chosen (before/after/replace link) :/
Comment #10
klonos... never mind, I did some further testing and I started a new issue: #904948: No icons are showing