Have ported the languageicons module to D7, here it is.

Comments

Freso’s picture

Status: Needs review » Needs work

Please provide the changes as a patch.

eMPee584’s picture

Status: Needs work » Needs review
StatusFileSize
new25.94 KB

patch -p1 < languageicons-d7-port.patch

Freso’s picture

Title: Port to D7: done. » Port Language Icons to D7
Status: Needs review » Needs work

Awesome work, thank you. :)

I found two issues though:

  1. Albeit minor, it will make it easier applying the patch, if CVS's own patch command is used. (I can't apply the current patch as it is, mostly because my languageicons folder doesn't have the folders "a" and "b"...)
  2. It seems like features that aren't currently in 6.x-2.x have gotten into this patch.
  3. It's great that you update the POT file as well! However, I notice that there are string changes as well. 7.x-1.x should be a direct port of 6.x-2.x, so there shouldn't be a difference in strings between the two.
Freso’s picture

StatusFileSize
new7.68 KB

While being mostly just style corrections (mostly guided by Coder), I have committed the attached patch for some initial 7.x compatibility. It's far from there yet, but it's a step towards it.

Freso’s picture

Version: 6.x-2.x-dev » 7.x-1.x-dev
Freso’s picture

Title: Port Language Icons to D7 » Port Language icons to D7
StatusFileSize
new2.58 KB

And I just got the theming in place, so that should work now as well.

Freso’s picture

Status: Needs work » Fixed
StatusFileSize
new1.69 KB

And this was apparently what was needed to actually make Language icons display some icons. Since it does that now, this issue is fixed. There are still some bugs though; like the fact that the code doesn't currently take the difference between the links in the block and at the node into account - but separate issues will have to be created for this and others.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

klonos’s picture

Status: Closed (fixed) » Active

Just started doing some testing with the latest Drupal 7.x-dev builds and I see no icons no matter what option is chosen (before/after/replace link) :/

klonos’s picture

Status: Active » Closed (fixed)

... never mind, I did some further testing and I started a new issue: #904948: No icons are showing