Just did a fresh install of a virtual machine and installed HEAD components.

The initial verify of the 'main' aegir site fails (fails to restart Apache), because it inserts the following components into its vhost config:

php_value session.cookie_secure 1
SSLEngine On

This is provided by provision/web_server/ssl/provision_ssl.drush.inc

function provision_ssl_provision_apache_vhost_config($url, $options) {
  drush_log("somewhere in provision_ssl, yay");
  if ($options['site_port'] == 443 || TRUE) {
    return array("php_value session.cookie_secure 1", "SSLEngine On");
  } else {
    return NULL;
  }
}

But I haven't set port 443..

Still looking into where its finding this to do so

Comments

Anonymous’s picture

Anonymous (not verified) commented

Ah. So it's in provision/web_server/provision_apache.drush.inc, line 108:

 $options['extra_config'] .= join("\n", drush_command_invoke_all('provision_apache_vhost_config', $url, $options));

This invokes the function above (provision_ssl_provision_apache_vhost_config($url, $options) ) in provision/web_server/ssl/provision_ssl.drush.inc

Oh.
And it totally skipped my eyes until I was writing this that someone was debugging or something here:

  if ($options['site_port'] == 443 || TRUE) {

obviously removing || TRUE fixes it. I've done so, removed the drush_log (we already log just prior to this that we're generating the apache vhost, so I don't think it's needed) and committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 0adcbc9 on debian, dev-dns, dev-envobject, dev-koumbit, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newhooks, dev-nginx, dev-platform_management, dev-ports, dev-purgebackup, dev-restore, dev-services, dev-simplerinstaller, dev-site_rename, dev-ssl, dev_716166_apache_conf, dev_dns, dev_server_verify, prod-koumbit, ssl, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by mig5: 
    #573422 - remove forced debugging that was putting SSL parameters into...