Tabs broken if navigation buttons disabled.

NigelCunningham - September 10, 2009 - 10:24
Project:Tabs (jQuery UI tabs)
Version:6.x-1.2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:reviewed & tested by the community
Description

I am using Tabs 1.2, together with CCK Fieldgroup tabs 6.x-1.0, and have observed that the tabs functionality breaks if I disable navigation buttons in the tabs configuration.

#1

nedjo - October 3, 2009 - 03:18

Steps to reproduce issue?

"breaks" how? Javascript errors?

#2

chaloalvarezj - October 13, 2009 - 01:04

I don't know if my case is related, but... The content of tabs are not shown when browsing with Internet Explorer 6 (Works perfectly with Firefox). Enabling navigation buttons, changes something but the content is still not shown.

Drupal 6.14
Tabs 6.x-1.2
cck fieldgroup_tabs 6.x-1.0 and the latest dev version
Viewfield 6.x-1.x-dev (latest)

The above was all working before the latest tabs release.

#3

NigelCunningham - October 22, 2009 - 23:54

Sorry for the slow response.

I've created a node type "Congregation" with data that I'm trying to put into tabs. I'm using cck_fieldgroup tabs too.

http://www.crca.org.au/AboutUs/WhoWeAre/Locations/Cobden shows an example.

With the nagivation buttons enabled, everything appears in the correct tabs and works fine.

Without the nagivation buttons enabled, the tabs appear but all of the content is on what would probably be counted as the 'basics' tab, and clicking on other tabs makes the content flash the first time you click, and move to where the relevant data is on the second click.

Since this is a live site, I've left navigation buttons enabled, but can switch them off temporarily if you want to see the effect. Please email me (ncunningham crca org au) if you'd like to see the broken version.

#4

Patrizio - December 15, 2009 - 00:08

Here is the code that solved the problem in my case, I hope it can be useful for you.

tabs.js, line 23

if ($(this).is('.tabs-navigation')) {
    Drupal.tabsNavigation(this);
}

replace with

if ($(this).is('.tabs-navigation')) {
    Drupal.tabsNavigation(this);
} else {
    $(this).tabs();
}

if there were not navigation, didn't applied the function tabs() to the tab

#5

NigelCunningham - December 16, 2009 - 05:38
Status:active» reviewed & tested by the community

Comment 4 fixes it for me.

Thanks Patrizio.

 
 

Drupal is a registered trademark of Dries Buytaert.