In the current code, if the cookie tastes bad, the code 'eats' it. This is poor metaphor compliance. I would expect that taste+ eat means that the cookie is good and the user is logged in while something like taste+ spit out, or taste+throw away represent the correct metaphor for a bad cookie and the user not getting logged in.

CommentFileSizeAuthor
#7 573888_toss_cookies-7.patch2.6 KBcoltrane
#6 573888_toss_cookies.patch2.52 KBgreggles

Comments

pwolanin’s picture

pwolanin commented
Title: you should not 'eat' a bad or poisoned cookied » you should not 'eat' a bad or poisoned cookie
stacie_a’s picture

stacie_a commented

i suppose bad cookies could be burnt cookies...

moshe weitzman’s picture

moshe weitzman commented

*crumble* the bad cookie

pwolanin’s picture

pwolanin commented

crumble is not bad - it shoudl be a verb that implies rejection somehow - crumble, spit, destroy, trash, reject...

stacie_a’s picture

stacie_a commented

toss, burn, compost, dogfood, vomit, birdfood, flush?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review
StatusFileSize
new 573888_toss_cookies.patch2.52 KB

I like the image of tossing the cookies best.

They are bad, my body rejects them.

coltrane’s picture

coltrane
he/him
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
StatusFileSize
new 573888_toss_cookies-7.patch2.6 KB

I don't really care what the metaphor is. #6 works but I altered some of the comments to remove references to eating.

And I assume #6 was for 6.x-dev.

juliangb’s picture

juliangb commented

Metaphor compliance is not important as long as you don't want anybody else to be able to understand (and contribute to) the code! Personally I dislike the fact we have so many metaphors when normal words would do.

I notice in #7 we are using destroy in the comments to explain toss. Could we therefore use destroy throughout? I think toss is a bit of an americanism in this context.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Makes sense to me.

I also agree that cutesy language in the code makes it harder to work on and we should consider a rewrite to get rid of all of the cutesy language.

coltrane’s picture

coltrane
he/him
commented
Status: Needs review » Postponed

Related #953376: Removing cookie metaphors

and marking this postponed

purencool’s picture

purencool commented
Version: 6.x-1.x-dev » 3.0.0-alpha1
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: you should not 'eat' a bad or poisoned cookie » You should not 'eat' a bad or poisoned cookie
Version: 3.0.0-alpha1 » 3.x-dev