user_access(NULL, NULL, TRUE) is only called internally from user.module.

We should apply a consistent DX standard for resetting static variables. Having some functions with a $reset parameter and some others using drupal_static() doesn't make sense.

CommentFileSizeAuthor
#4 drupal.user-access-reset.4.patch7.02 KBsun
#2 drupal.user-access-reset.2.patch6.84 KBsun
drupal.user-access-reset.patch4.34 KBsun

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal.user-access-reset.2.patch6.84 KB

oh wow - a pass-through $reset parameter! :)

And. A missing cache flush in user_role_save()! ;)

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal.user-access-reset.4.patch7.02 KB
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks great!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -API clean-up

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +API clean-up

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.