Values for sub sites and cookie key, age, domain and selected profile fields are not removed when bakery is uninstalled manually.

Do those variables need to be cleared.

Are there any other variables that need to be cleared?

Additionally, what happens when a site removes bakery, is login once again allowed by each site concurrently?

And what if, down the line, someone re-installs bakery, does the data need to be fixed/copied, or does the master once again just take over.

CommentFileSizeAuthor
#10 bakery--574160-10.patch775 bytesjuliangb
#3 bakery.install.txt675 bytesjuliangb

Comments

thomasmuirhead’s picture

Hi there,

I've had the same problem. After installing bakery on two sites, and trying to remove it, the Master site won't let me access the /user page - so I have no way of logging in.

Anyone got any ideas? Would deleting something from the database help? Or some way of switching admin permissions to everyone for a short while or something so I can get back in.

thanks

Thomas

thomasmuirhead’s picture

To update,

one of the other members was able to log in by virtue of having his login saved in his firefox from before I installed Bakery....he then put the login box on the front page and I can now log in through that...but still can't access the path user/. Any reason why that path might not be working...I just get a blank page - complete white screen.

Any thoughts?

juliangb’s picture

Status: Active » Needs review
StatusFileSize
new675 bytes

Attached is a .install file containing implementations of hook_disable and hook_uninstall. Needs the .txt removed due to drupal.org upload restrictions.

The question is whether the aliases should be reinserted on hook_enable - however, I can see issues with that for new installations, because then we'd have overridden user/login and user/register immediately on enabling (#766616: Default to master site would help this, as we could then do a check of the variable 'bakery_is_master' in hook_enable, and new sites wouldn't get the aliases until the admin settings form had been submitted.)

This is the D6 version - the changes for D7 can happen here or as part of the port depending on which progresses first.

steven jones’s picture

@juliangb You might want to take a quick look at the 'Adding/Deleting Files Using the Diff Command' section on the handbook page here: http://drupal.org/patch/create. If you use fake add it makes it really easy to upload new files as patches, then no silly renaming! CVS is so silly.

greggles’s picture

Title: Bakery has no Uninstall (unbake?) » Bakery has no Uninstall (unbake?) and could do more in the install
Status: Needs review » Needs work

Seems good to me.

I suggest we expand this to include saving the aliases directly.

Also, there is an api for creating and deleting aliases. We should use it :) http://api.drupal.org/api/function/path_set_alias

greggles’s picture

Pardon, to clarify my last comment - I suggest we move the creation of the aliases out of a form submit function and into the .install.

juliangb’s picture

Just to note that I think we should solve this problem with paths before doing anything in .install.

I've just noted in #787090: Use hook_menu_alter rather than aliases about how we're using functionality from an optional module... (I won't repeat all here).

mynode’s picture

I ran into a problem where I installed and enabled bakery and then disabled it and couldn't get the "Create new account" page (not found). I solved it by re-enabling bakery, setting local instance to master and then disabling bakery.

greggles’s picture

@mynode that probably would have been solved by clearing the menu cache as well.

juliangb’s picture

StatusFileSize
new775 bytes

Totally taking out the bit about path aliases in anticipation of #787090: Use hook_menu_alter rather than aliases, the attached patch should work for D7 and D6 and sorts out just the removal of variables.

juliangb’s picture

Status: Needs work » Needs review

Status change.

purencool’s picture

Issue summary: View changes
Status: Needs review » Closed (outdated)
avpaderno’s picture

Version: 7.x-1.x-dev » 3.0.0-alpha1
Status: Closed (outdated) » Needs work
Issue tags: +Needs reroll

The module still does not implement hook_install() and hook_uninstall(), even in the 3.x branch.

purencool’s picture

Status: Needs work » Active
avpaderno’s picture

Version: 3.0.0-alpha1 » 3.x-dev
Status: Active » Needs work
Issue tags: +Needs merge request