Popup editor: "OK" does nothing, can't edit block
Garrett Albright - September 10, 2009 - 21:42
| Project: | FCKeditor - WYSIWYG HTML editor |
| Version: | 6.x-1.4-rc2 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Jorrit |
| Status: | closed |
Jump to:
Description
The attached patch should fix two issues which seem to have been introduced recently in the JS code in fckeditor.popup.html.
1. A leftover debug line was preventing content from being transferred from the editor to the Body field when "OK" was clicked in FF and IE at least.
2. Editing block content wasn't working because the editor was trying to put text in a non-existent teaser field.
| Attachment | Size |
|---|---|
| fckeditor-bugs.patch | 1.69 KB |
#1
You're absolutely right about the console.log. I didn't check for teaser === null, because I only attach the teaser GET parameter when there is a teaser. But checking again doesn't hurt, I think. Is the
===comparison also valid in JS? I thought it was only valid in PHP.#2
Sure it is. Try running
1 == '1'and1 === '1'in the Firebug console or similar and you'll see it behaves as it does in PHP.#3
I have committed a fix, slightly different than your patch. You will be able to find it in the next -dev release, which are built nightly. I hope you like it.
#4
#5
Automatically closed -- issue fixed for 2 weeks with no activity.