Download & Extend
footermap: a footer site map » Issues

Parent menus with no children appear as parent of next sibling

Posted by mstrelan on September 11, 2009 at 3:38am
Project:footermap: a footer site map
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

If you have a structure like this ...

Home
About us
--Contact us
--Visit us
Whats on
--Events
--Attractions

It appears like this ...

Home
--About us
--Contact us
--Visit us
Whats on
--Events
--Attractions

Patch attached, needs testing

AttachmentSize
footermap.module.patch14.7 KB
Login or register to post comments

Comments

#1

Posted by mradcliffe on September 15, 2009 at 3:37pm

I'll have to take a look at this in a couple of weeks. I'll be away on vacation starting tomorrow.

#2

Posted by mradcliffe on October 8, 2009 at 6:48pm
Version:6.x-1.5» 6.x-1.x-dev
Status:active» needs work

I don't see any changes in this patch. Can you resubmit based on DRUPAL-6--1 tag?

#3

Posted by mstrelan on October 13, 2009 at 3:43am

The difference is the position of the braces in this bit

            if( $h->has_children == 1 )
            {
                footermap_get_menu($h->mlid, $level+1, $limit, $mapref, $arrcnt,array($h->menu_name => $h->menu_name));
                if( $level == 1 )
                    $arrcnt++;
            }

#4

Posted by mradcliffe on October 14, 2009 at 3:06pm
Status:needs work» patch (to be ported)

Okay, thanks, I've committed this.

#5

Posted by mradcliffe on November 19, 2009 at 7:42pm
Status:patch (to be ported)» fixed

#6

Posted by System Message on December 3, 2009 at 7:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here